Bug 98340 – Add code for input[type=date] with the multiple fields UI

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Add code for input[type=date] with the multiple fields UI

[Kent Tamura]

Created attachment 167040 [details]
Patch

[Hajime Morrita]

Comment on attachment 167040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167040&action=review

Basically looks good. Hope we have tests soon.

> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h:93
> +    bool m_pickerIndicatorIsAlwaysVisible;

Do we need this member variable? It looks this can be computed on the fly.

[Kent Tamura]

Comment on attachment 167040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167040&action=review

>> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h:93
>> +    bool m_pickerIndicatorIsAlwaysVisible;
> 
> Do we need this member variable? It looks this can be computed on the fly.

It is referred in BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility.

[Kent Tamura]

(In reply to comment #3)
> (From update of attachment 167040 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167040&action=review
> 
> >> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h:93
> >> +    bool m_pickerIndicatorIsAlwaysVisible;
> > 
> > Do we need this member variable? It looks this can be computed on the fly.
> 
> It is referred in BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility.

Oh, did you mean calling RenderTheme::supportsCalendarPicker in updatePickerIndicatorVisibility?  You're right.  I'll fix later.

[WebKit Review Bot]

Comment on attachment 167040 [details]
Patch

Clearing flags on attachment: 167040

Committed r130369: <http://trac.webkit.org/changeset/130369>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.