Bug 98340 - Add code for input[type=date] with the multiple fields UI
Summary: Add code for input[type=date] with the multiple fields UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 98226
  Show dependency tree / graph
 
Reported: 2012-10-03 22:39 PDT by Kent Tamura
Modified: 2012-10-04 00:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (20.58 KB, patch)
2012-10-03 23:33 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-10-03 22:39:42 PDT 
Add code for input[type=date] with the multiple fields UI
Comment 1 Kent Tamura 2012-10-03 23:33:45 PDT 
Created attachment 167040 [details]
Patch
Comment 2 Hajime Morrita 2012-10-04 00:22:59 PDT 
Comment on attachment 167040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167040&action=review

Basically looks good. Hope we have tests soon.

> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h:93
> +    bool m_pickerIndicatorIsAlwaysVisible;

Do we need this member variable? It looks this can be computed on the fly.
Comment 3 Kent Tamura 2012-10-04 00:24:58 PDT 
Comment on attachment 167040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167040&action=review

>> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h:93
>> +    bool m_pickerIndicatorIsAlwaysVisible;
> 
> Do we need this member variable? It looks this can be computed on the fly.

It is referred in BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility.
Comment 4 Kent Tamura 2012-10-04 00:42:42 PDT 
(In reply to comment #3)
> (From update of attachment 167040 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167040&action=review
> 
> >> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h:93
> >> +    bool m_pickerIndicatorIsAlwaysVisible;
> > 
> > Do we need this member variable? It looks this can be computed on the fly.
> 
> It is referred in BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility.

Oh, did you mean calling RenderTheme::supportsCalendarPicker in updatePickerIndicatorVisibility?  You're right.  I'll fix later.
Comment 5 WebKit Review Bot 2012-10-04 00:49:48 PDT 
Comment on attachment 167040 [details]
Patch

Clearing flags on attachment: 167040

Committed r130369: <http://trac.webkit.org/changeset/130369>
Comment 6 WebKit Review Bot 2012-10-04 00:49:51 PDT 
All reviewed patches have been landed.  Closing bug.