Bug 98335 - Use copyLCharsFromUCharSource() for IdentifierLCharFromUCharTranslator translation
Summary: Use copyLCharsFromUCharSource() for IdentifierLCharFromUCharTranslator transl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 18:03 PDT by Benjamin Poulain
Modified: 2012-10-04 14:37 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.83 KB, patch)
2012-10-03 18:11 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-10-03 18:03:44 PDT
Let's use the optimized version :)
Comment 1 Benjamin Poulain 2012-10-03 18:11:42 PDT
Created attachment 167014 [details]
Patch
Comment 2 Benjamin Poulain 2012-10-04 12:34:13 PDT
Comment on attachment 167014 [details]
Patch

Clearing flags on attachment: 167014

Committed r130418: <http://trac.webkit.org/changeset/130418>
Comment 3 Benjamin Poulain 2012-10-04 12:34:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2012-10-04 14:37:32 PDT
It’s kind of bad that copyLCharsFromUCharSource is in ASCIIFastPath.h, because LChar allows non-ASCII characters. The header may need a new name or something.
Comment 5 Darin Adler 2012-10-04 14:37:58 PDT
Comment on attachment 167014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167014&action=review

> Source/JavaScriptCore/runtime/Identifier.cpp:84
> +        WTF::copyLCharsFromUCharSource(d, buf.s, buf.length);

The explicit WTF here is strange, and should not be needed if ASCIIFastPath follows the normal using model we use for WTF headers.