Bug 98331 – Remove unused features of BlobBuilder

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Remove unused features of BlobBuilder

[Adam Barth]

Created attachment 167002 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 167002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167002&action=review

Hot damn!

> Source/WebCore/page/FeatureObserver.h:44
> +        UnusedSlot01, // Prior to 10/2012, we used this slot for LegacyBlobBuilder.

Are you trying to maintain binary compat?

[Adam Barth]

(In reply to comment #2)
> (From update of attachment 167002 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167002&action=review
> 
> Hot damn!
> 
> > Source/WebCore/page/FeatureObserver.h:44
> > +        UnusedSlot01, // Prior to 10/2012, we used this slot for LegacyBlobBuilder.
> 
> Are you trying to maintain binary compat?

Yes.  The enum values are stored on the server.  We can re-use values once we don't care about cross-talk with older versions.

[WebKit Review Bot]

Comment on attachment 167002 [details]
Patch

Rejecting attachment 167002 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14209658

[WebKit Review Bot]

Comment on attachment 167002 [details]
Patch

Clearing flags on attachment: 167002

Committed r130705: <http://trac.webkit.org/changeset/130705>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.