Bug 98331 - Remove unused features of BlobBuilder
Summary: Remove unused features of BlobBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 17:11 PDT by Adam Barth
Modified: 2012-10-08 17:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.59 KB, patch)
2012-10-03 17:13 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-10-03 17:11:18 PDT 
Remove unused features of BlobBuilder
Comment 1 Adam Barth 2012-10-03 17:13:23 PDT 
Created attachment 167002 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-08 16:07:55 PDT 
Comment on attachment 167002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167002&action=review

Hot damn!

> Source/WebCore/page/FeatureObserver.h:44
> +        UnusedSlot01, // Prior to 10/2012, we used this slot for LegacyBlobBuilder.

Are you trying to maintain binary compat?
Comment 3 Adam Barth 2012-10-08 16:10:47 PDT 
(In reply to comment #2)
> (From update of attachment 167002 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167002&action=review
> 
> Hot damn!
> 
> > Source/WebCore/page/FeatureObserver.h:44
> > +        UnusedSlot01, // Prior to 10/2012, we used this slot for LegacyBlobBuilder.
> 
> Are you trying to maintain binary compat?

Yes.  The enum values are stored on the server.  We can re-use values once we don't care about cross-talk with older versions.
Comment 4 WebKit Review Bot 2012-10-08 16:17:05 PDT 
Comment on attachment 167002 [details]
Patch

Rejecting attachment 167002 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14209658
Comment 5 WebKit Review Bot 2012-10-08 17:08:51 PDT 
Comment on attachment 167002 [details]
Patch

Clearing flags on attachment: 167002

Committed r130705: <http://trac.webkit.org/changeset/130705>
Comment 6 WebKit Review Bot 2012-10-08 17:08:55 PDT 
All reviewed patches have been landed.  Closing bug.