RESOLVED FIXED 98327
Simplify attribute access in Element::computeInheritedLanguage 
https://bugs.webkit.org/show_bug.cgi?id=98327
Summary Simplify attribute access in Element::computeInheritedLanguage
Benjamin Poulain
Reported 2012-10-03 16:43:48 PDT
Small optimization.
Attachments
Patch (2.39 KB, patch)
2012-10-03 16:49 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (2.38 KB, patch)
2012-10-03 17:32 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-10-03 16:49:51 PDT
Created attachment 166993 [details] Patch
Andreas Kling
Comment 2 2012-10-03 16:53:41 PDT
Comment on attachment 166993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166993&action=review r=me, though I suspect you could save a couple more cycles here by doing a custom loop over the attributeData->attributeItem()s. > Source/WebCore/dom/Element.cpp:1762 > + ElementAttributeData* attributeData = static_cast<const Element*>(n)->attributeData(); > + if (attributeData) { Scope 'attributeData' to the if.
Gyuyoung Kim
Comment 3 2012-10-03 17:03:17 PDT
Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14123896
Build Bot
Comment 4 2012-10-03 17:06:21 PDT
Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14126975
Early Warning System Bot
Comment 5 2012-10-03 17:07:16 PDT
Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14125978
WebKit Review Bot
Comment 6 2012-10-03 17:17:46 PDT
Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14129849
Early Warning System Bot
Comment 7 2012-10-03 17:28:43 PDT
Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14138773
Benjamin Poulain
Comment 8 2012-10-03 17:32:19 PDT
Created attachment 167006 [details] Patch
Benjamin Poulain
Comment 9 2012-10-03 18:53:10 PDT
Comment on attachment 167006 [details] Patch Clearing flags on attachment: 167006 Committed r130354: <http://trac.webkit.org/changeset/130354>
Benjamin Poulain
Comment 10 2012-10-03 18:53:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.