Bug 98327 - Simplify attribute access in Element::computeInheritedLanguage
Summary: Simplify attribute access in Element::computeInheritedLanguage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 16:43 PDT by Benjamin Poulain
Modified: 2012-10-03 18:53 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.39 KB, patch)
2012-10-03 16:49 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (2.38 KB, patch)
2012-10-03 17:32 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-10-03 16:43:48 PDT 
Small optimization.
Comment 1 Benjamin Poulain 2012-10-03 16:49:51 PDT 
Created attachment 166993 [details]
Patch
Comment 2 Andreas Kling 2012-10-03 16:53:41 PDT 
Comment on attachment 166993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166993&action=review

r=me, though I suspect you could save a couple more cycles here by doing a custom loop over the attributeData->attributeItem()s.

> Source/WebCore/dom/Element.cpp:1762
> +            ElementAttributeData* attributeData = static_cast<const Element*>(n)->attributeData();
> +            if (attributeData) {

Scope 'attributeData' to the if.
Comment 3 Gyuyoung Kim 2012-10-03 17:03:17 PDT 
Comment on attachment 166993 [details]
Patch

Attachment 166993 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14123896
Comment 4 Build Bot 2012-10-03 17:06:21 PDT 
Comment on attachment 166993 [details]
Patch

Attachment 166993 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14126975
Comment 5 Early Warning System Bot 2012-10-03 17:07:16 PDT 
Comment on attachment 166993 [details]
Patch

Attachment 166993 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14125978
Comment 6 WebKit Review Bot 2012-10-03 17:17:46 PDT 
Comment on attachment 166993 [details]
Patch

Attachment 166993 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14129849
Comment 7 Early Warning System Bot 2012-10-03 17:28:43 PDT 
Comment on attachment 166993 [details]
Patch

Attachment 166993 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14138773
Comment 8 Benjamin Poulain 2012-10-03 17:32:19 PDT 
Created attachment 167006 [details]
Patch
Comment 9 Benjamin Poulain 2012-10-03 18:53:10 PDT 
Comment on attachment 167006 [details]
Patch

Clearing flags on attachment: 167006

Committed r130354: <http://trac.webkit.org/changeset/130354>
Comment 10 Benjamin Poulain 2012-10-03 18:53:13 PDT 
All reviewed patches have been landed.  Closing bug.