Bug 98301 - Remove support for ENABLE(LEGACY_WEBKIT_BLOB_BUILDER)
Summary: Remove support for ENABLE(LEGACY_WEBKIT_BLOB_BUILDER)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2012-10-03 14:17 PDT by Adam Barth
Modified: 2012-10-04 02:40 PDT (History)
15 users (show)

See Also:

Attachments
Patch (10.96 KB, patch)
2012-10-03 14:18 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (19.90 KB, patch)
2012-10-03 15:01 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (27.20 KB, patch)
2012-10-03 15:56 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-10-03 14:17:30 PDT 
Remove support for ENABLE(LEGACY_WEBKIT_BLOB_BUILDER)
Comment 1 Adam Barth 2012-10-03 14:18:54 PDT 
Created attachment 166958 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-03 14:19:51 PDT 
Comment on attachment 166958 [details]
Patch

LGTM.
Comment 3 Adam Barth 2012-10-03 14:21:43 PDT 
@Aaron: The string WebKitBlobBuilder shows up in some extensions, but the 0.006% figure includes usage by extensions.
Comment 4 Early Warning System Bot 2012-10-03 14:42:31 PDT 
Comment on attachment 166958 [details]
Patch

Attachment 166958 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14168017
Comment 5 kov's GTK+ EWS bot 2012-10-03 14:43:10 PDT 
Comment on attachment 166958 [details]
Patch

Attachment 166958 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14132771
Comment 6 Early Warning System Bot 2012-10-03 14:51:55 PDT 
Comment on attachment 166958 [details]
Patch

Attachment 166958 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14132777
Comment 7 Build Bot 2012-10-03 14:55:55 PDT 
Comment on attachment 166958 [details]
Patch

Attachment 166958 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14135799
Comment 8 Adam Barth 2012-10-03 14:57:39 PDT 
Comment on attachment 166958 [details]
Patch

More build system cruft to remove.
Comment 9 Adam Barth 2012-10-03 15:01:06 PDT 
Created attachment 166966 [details]
Patch
Comment 10 Raphael Kubo da Costa (:rakuco) 2012-10-03 15:19:49 PDT 
Is the build system part (FeatureLists.pm and definitions for each build system) going to be cleaned up in another patch?
Comment 11 Adam Barth 2012-10-03 15:53:12 PDT 
(In reply to comment #10)
> Is the build system part (FeatureLists.pm and definitions for each build system) going to be cleaned up in another patch?

Oh, I see that there's more stuff in the Tools directory.  Yeah, I'll do that shortly after this patch lands.  Thanks for the tip.
Comment 12 Adam Barth 2012-10-03 15:54:30 PDT 
Comment on attachment 166966 [details]
Patch

Actually, let me do it in one patch.
Comment 13 Adam Barth 2012-10-03 15:56:54 PDT 
Created attachment 166980 [details]
Patch for landing
Comment 14 WebKit Review Bot 2012-10-03 16:38:38 PDT 
Comment on attachment 166980 [details]
Patch for landing

Clearing flags on attachment: 166980

Committed r130343: <http://trac.webkit.org/changeset/130343>
Comment 15 WebKit Review Bot 2012-10-03 16:38:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 16 Roger Fong 2012-10-03 18:14:27 PDT 
So I can't seem to open the WebCore project on Windows in visual studio anymore after this patch :/

The following error has occurred during XML parsing:

File: C:\cygwin\home\buildbot\WebKit\OpenSource\Source\WebCore\WebCore.vcproj\WebCore.vcproj
Line: 22958
Column: 4
Error Message:
Illegal qualified name character.

The file 'C:\cygwin\home\buildbot\WebKit\OpenSource\Source\WebCore\WebCore.vcproj\WebCore.vcproj' has failed to load.


Any idea why?
Comment 17 Adam Barth 2012-10-03 19:37:29 PDT 
Comment on attachment 166980 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=166980&action=review

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:22957
>  			<File

Yes.  Looks like we need to delete this line as well.
Comment 18 Adam Barth 2012-10-03 20:42:44 PDT 
Should be fixed in http://trac.webkit.org/changeset/130358
Comment 19 Roger Fong 2012-10-03 22:06:37 PDT 
Great! Thank you much
Comment 20 Raphael Kubo da Costa (:rakuco) 2012-10-04 01:47:34 PDT 
I removed one last trace of $legacyWebKitBlobBuilderSupport in <http://trac.webkit.org/changeset/130372>.
Comment 21 Adam Barth 2012-10-04 01:49:12 PDT 
Thanks.
Comment 23 Adam Barth 2012-10-04 02:40:06 PDT 
I'll fix the tests tomorrow.  They're likely just using the API we removed.