Bug 98301 – Remove support for ENABLE(LEGACY_WEBKIT_BLOB_BUILDER)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Remove support for ENABLE(LEGACY_WEBKIT_BLOB_BUILDER)

[Adam Barth]

Created attachment 166958 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 166958 [details]
Patch

LGTM.

[Adam Barth]

@Aaron: The string WebKitBlobBuilder shows up in some extensions, but the 0.006% figure includes usage by extensions.

[Early Warning System Bot]

Comment on attachment 166958 [details]
Patch

Attachment 166958 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14168017

[kov's GTK+ EWS bot]

Comment on attachment 166958 [details]
Patch

Attachment 166958 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14132771

[Early Warning System Bot]

Comment on attachment 166958 [details]
Patch

Attachment 166958 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14132777

[Build Bot]

Comment on attachment 166958 [details]
Patch

Attachment 166958 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14135799

[Adam Barth]

Comment on attachment 166958 [details]
Patch

More build system cruft to remove.

[Adam Barth]

Created attachment 166966 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Is the build system part (FeatureLists.pm and definitions for each build system) going to be cleaned up in another patch?

[Adam Barth]

(In reply to comment #10)
> Is the build system part (FeatureLists.pm and definitions for each build system) going to be cleaned up in another patch?

Oh, I see that there's more stuff in the Tools directory.  Yeah, I'll do that shortly after this patch lands.  Thanks for the tip.

[Adam Barth]

Comment on attachment 166966 [details]
Patch

Actually, let me do it in one patch.

[Adam Barth]

Created attachment 166980 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 166980 [details]
Patch for landing

Clearing flags on attachment: 166980

Committed r130343: <http://trac.webkit.org/changeset/130343>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Roger Fong]

So I can't seem to open the WebCore project on Windows in visual studio anymore after this patch :/

The following error has occurred during XML parsing:

File: C:\cygwin\home\buildbot\WebKit\OpenSource\Source\WebCore\WebCore.vcproj\WebCore.vcproj
Line: 22958
Column: 4
Error Message:
Illegal qualified name character.

The file 'C:\cygwin\home\buildbot\WebKit\OpenSource\Source\WebCore\WebCore.vcproj\WebCore.vcproj' has failed to load.


Any idea why?

[Adam Barth]

Comment on attachment 166980 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=166980&action=review

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:22957
>  			<File

Yes.  Looks like we need to delete this line as well.

[Adam Barth]

Should be fixed in http://trac.webkit.org/changeset/130358

[Roger Fong]

Great! Thank you much

[Raphael Kubo da Costa (:rakuco)]

I removed one last trace of $legacyWebKitBlobBuilderSupport in <http://trac.webkit.org/changeset/130372>.

[Adam Barth]

Thanks.

[Yury Semikhatsky]

This change broke Chromium Mac 10.6 canary:
http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/13794

The tests output:
http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/13794/steps/browser_tests/logs/Iframes
http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/13794/steps/browser_tests/logs/DownloadDangerousBlobData

[Adam Barth]

I'll fix the tests tomorrow.  They're likely just using the API we removed.