Bug 98287 - Crash when calling document.open during unload
: Crash when calling document.open during unload
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
: 98345
:
  Show dependency treegraph
 
Reported: 2012-10-03 11:51 PST by
Modified: 2012-10-04 00:36 PST (History)


Attachments
Patch (3.31 KB, patch)
2012-10-03 11:53 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-10-03 11:51:53 PST
Crash when calling document.open during unload
------- Comment #1 From 2012-10-03 11:53:53 PST -------
Created an attachment (id=166931) [details]
Patch
------- Comment #2 From 2012-10-03 11:56:44 PST -------
(From update of attachment 166931 [details])
Will this crash the current test or the next one without the patch?
------- Comment #3 From 2012-10-03 12:06:59 PST -------
> Will this crash the current test or the next one without the patch?

The current one.
------- Comment #4 From 2012-10-03 12:08:55 PST -------
(From update of attachment 166931 [details])
Ok. I just get worried about unload events causing their failures too late.
------- Comment #5 From 2012-10-03 12:34:21 PST -------
(From update of attachment 166931 [details])
Clearing flags on attachment: 166931

Committed r130313: <http://trac.webkit.org/changeset/130313>
------- Comment #6 From 2012-10-03 12:34:24 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #7 From 2012-10-04 00:07:06 PST -------
(In reply to comment #5)
> (From update of attachment 166931 [details] [details])
> Clearing flags on attachment: 166931
> 
> Committed r130313: <http://trac.webkit.org/changeset/130313>

It caused a crash on the Qt WK2 bot - https://bugs.webkit.org/show_bug.cgi?id=98345
Could you check it, please?
------- Comment #8 From 2012-10-04 00:36:41 PST -------
Sounds like this test uncovered an existing crash in WebKit2.  There's no way this patch introduced the crash.  (The patch is just a null check.)