Bug 98287 - Crash when calling document.open during unload
Summary: Crash when calling document.open during unload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 98345
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-03 11:51 PDT by Adam Barth
Modified: 2018-06-28 21:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.31 KB, patch)
2012-10-03 11:53 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-10-03 11:51:53 PDT 
Crash when calling document.open during unload
Comment 1 Adam Barth 2012-10-03 11:53:53 PDT 
Created attachment 166931 [details]
Patch
Comment 2 Nate Chapin 2012-10-03 11:56:44 PDT 
Comment on attachment 166931 [details]
Patch

Will this crash the current test or the next one without the patch?
Comment 3 Adam Barth 2012-10-03 12:06:59 PDT 
> Will this crash the current test or the next one without the patch?

The current one.
Comment 4 Nate Chapin 2012-10-03 12:08:55 PDT 
Comment on attachment 166931 [details]
Patch

Ok. I just get worried about unload events causing their failures too late.
Comment 5 WebKit Review Bot 2012-10-03 12:34:21 PDT 
Comment on attachment 166931 [details]
Patch

Clearing flags on attachment: 166931

Committed r130313: <http://trac.webkit.org/changeset/130313>
Comment 6 WebKit Review Bot 2012-10-03 12:34:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Csaba Osztrogonác 2012-10-04 00:07:06 PDT 
(In reply to comment #5)
> (From update of attachment 166931 [details])
> Clearing flags on attachment: 166931
> 
> Committed r130313: <http://trac.webkit.org/changeset/130313>

It caused a crash on the Qt WK2 bot - https://bugs.webkit.org/show_bug.cgi?id=98345
Could you check it, please?
Comment 8 Adam Barth 2012-10-04 00:36:41 PDT 
Sounds like this test uncovered an existing crash in WebKit2.  There's no way this patch introduced the crash.  (The patch is just a null check.)