RESOLVED FIXED 98281
Add a performance test for subtree detaching 
https://bugs.webkit.org/show_bug.cgi?id=98281
Summary Add a performance test for subtree detaching
Julien Chaffraix
Reported 2012-10-03 10:48:49 PDT
Currently we don't have a test stressing only detaching. When tested, it is usually done in combination with other phases such as layout without thinking about the interactions. This is important as our current detaching algorithm is inefficient, leading to several traversal to the root as we generate multiple repaints. See bug 92697 for example where Eric came to the same conclusion. I would like to change how we detach thus the need for some performance coverage.
Attachments
Proposed test, welcome suggestions on how to better stress detaching. (2.24 KB, patch)
2012-10-03 11:01 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-10-03 11:01:22 PDT
Created attachment 166923 [details] Proposed test, welcome suggestions on how to better stress detaching.
Eric Seidel (no email)
Comment 2 2012-10-03 13:18:56 PDT
Comment on attachment 166923 [details] Proposed test, welcome suggestions on how to better stress detaching. SGTM. Might make more sense to add this with your first perf fix though. :)
Julien Chaffraix
Comment 3 2012-10-03 16:22:06 PDT
Comment on attachment 166923 [details] Proposed test, welcome suggestions on how to better stress detaching. > SGTM. Might make more sense to add this with your first perf fix though. :) Thanks Eric, the idea is to see the improvements as we go. Also it increases our coverage regardless of whether we follow the optimizations to their end.
WebKit Review Bot
Comment 4 2012-10-03 16:28:38 PDT
Comment on attachment 166923 [details] Proposed test, welcome suggestions on how to better stress detaching. Clearing flags on attachment: 166923 Committed r130341: <http://trac.webkit.org/changeset/130341>
WebKit Review Bot
Comment 5 2012-10-03 16:28:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.