Bug 98263 - Change RTCPeerConnection GetStats to use Date timestamp format
Summary: Change RTCPeerConnection GetStats to use Date timestamp format
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 98392
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-03 07:24 PDT by Harald Alvestrand
Modified: 2012-10-04 04:06 PDT (History)
9 users (show)

See Also:


Attachments
Patch (14.17 KB, patch)
2012-10-03 07:32 PDT, Harald Alvestrand
no flags Details | Formatted Diff | Diff
Patch (14.14 KB, patch)
2012-10-04 01:50 PDT, Harald Alvestrand
no flags Details | Formatted Diff | Diff
Patch (14.04 KB, patch)
2012-10-04 03:34 PDT, Harald Alvestrand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Alvestrand 2012-10-03 07:24:14 PDT
The timestamp format in GetStats was set to "long", which won't work on a 32-bit system.
This should be changed to "Date" in IDL, and "double" in C++.
Comment 1 Harald Alvestrand 2012-10-03 07:32:10 PDT
Created attachment 166889 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-03 07:35:08 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-10-03 11:03:28 PDT
Comment on attachment 166889 [details]
Patch

Rejecting attachment 166889 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 154708 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
51>At revision 154708.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14152187
Comment 4 Adam Barth 2012-10-03 11:05:06 PDT
Comment on attachment 166889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166889&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests (OOPS!).

You should remove this line since you've explained where the tests are in the previous line.
Comment 5 Harald Alvestrand 2012-10-04 01:50:14 PDT
Created attachment 167052 [details]
Patch
Comment 6 WebKit Review Bot 2012-10-04 02:14:47 PDT
Comment on attachment 167052 [details]
Patch

Clearing flags on attachment: 167052

Committed r130377: <http://trac.webkit.org/changeset/130377>
Comment 7 WebKit Review Bot 2012-10-04 02:14:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2012-10-04 03:00:40 PDT
Re-opened since this is blocked by bug 98392
Comment 9 Harald Alvestrand 2012-10-04 03:34:06 PDT
Created attachment 167065 [details]
Patch
Comment 10 Yury Semikhatsky 2012-10-04 03:57:29 PDT
Comment on attachment 167065 [details]
Patch

rs=me
Comment 11 WebKit Review Bot 2012-10-04 04:06:21 PDT
Comment on attachment 167065 [details]
Patch

Clearing flags on attachment: 167065

Committed r130383: <http://trac.webkit.org/changeset/130383>
Comment 12 WebKit Review Bot 2012-10-04 04:06:26 PDT
All reviewed patches have been landed.  Closing bug.