Bug 98253 - [EFL][WK2] Implement focus/unfocus in UIClient
Summary: [EFL][WK2] Implement focus/unfocus in UIClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 03:41 PDT by Chris Dumez
Modified: 2012-10-03 07:32 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.07 KB, patch)
2012-10-03 05:05 PDT, Chris Dumez 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
Patch for landing (2.12 KB, patch)
2012-10-03 06:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-03 03:41:00 PDT 
We currently don't implement focus/unfocus callbacks in EwkView UIClient. We should provide an implementation for those.
Comment 1 Chris Dumez 2012-10-03 05:05:52 PDT 
Created attachment 166860 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-10-03 05:56:36 PDT 
Comment on attachment 166860 [details]
Patch

LGTM.
Comment 3 Gyuyoung Kim 2012-10-03 06:22:17 PDT 
Comment on attachment 166860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166860&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:95
> +    evas_object_focus_set(toEwkView(clientInfo), false);

BTW, I wonder why we support *takeFocus* as *unfocus* functionality. In mac port and qt port, they process this with other way.
Comment 4 Chris Dumez 2012-10-03 06:24:14 PDT 
Comment on attachment 166860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166860&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:95
>> +    evas_object_focus_set(toEwkView(clientInfo), false);
> 
> BTW, I wonder why we support *takeFocus* as *unfocus* functionality. In mac port and qt port, they process this with other way.

Yes, takeFocus() implementation is not complete but we do the same in WebKit1.
Comment 5 Gyuyoung Kim 2012-10-03 06:52:45 PDT 
(In reply to comment #4)
> (From update of attachment 166860 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166860&action=review
> 
> >> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:95
> >> +    evas_object_focus_set(toEwkView(clientInfo), false);
> > 
> > BTW, I wonder why we support *takeFocus* as *unfocus* functionality. In mac port and qt port, they process this with other way.
> 
> Yes, takeFocus() implementation is not complete but we do the same in WebKit1.

Ok. IMO, it would be good if you say this using "FIXME: bla bla".
Comment 6 Chris Dumez 2012-10-03 06:59:10 PDT 
Created attachment 166885 [details]
Patch for landing

Take Gyuyoung's feedback into consideration.
Comment 7 WebKit Review Bot 2012-10-03 07:32:22 PDT 
Comment on attachment 166885 [details]
Patch for landing

Clearing flags on attachment: 166885

Committed r130285: <http://trac.webkit.org/changeset/130285>
Comment 8 WebKit Review Bot 2012-10-03 07:32:27 PDT 
All reviewed patches have been landed.  Closing bug.