Bug 98253 – [EFL][WK2] Implement focus/unfocus in UIClient

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

We currently don't implement focus/unfocus callbacks in EwkView UIClient. We should provide an implementation for those.

[Chris Dumez]

Created attachment 166860 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 166860 [details]
Patch

LGTM.

[Gyuyoung Kim]

Comment on attachment 166860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166860&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:95
> +    evas_object_focus_set(toEwkView(clientInfo), false);

BTW, I wonder why we support *takeFocus* as *unfocus* functionality. In mac port and qt port, they process this with other way.

[Chris Dumez]

Comment on attachment 166860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166860&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:95
>> +    evas_object_focus_set(toEwkView(clientInfo), false);
> 
> BTW, I wonder why we support *takeFocus* as *unfocus* functionality. In mac port and qt port, they process this with other way.

Yes, takeFocus() implementation is not complete but we do the same in WebKit1.

[Gyuyoung Kim]

(In reply to comment #4)
> (From update of attachment 166860 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166860&action=review
> 
> >> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:95
> >> +    evas_object_focus_set(toEwkView(clientInfo), false);
> > 
> > BTW, I wonder why we support *takeFocus* as *unfocus* functionality. In mac port and qt port, they process this with other way.
> 
> Yes, takeFocus() implementation is not complete but we do the same in WebKit1.

Ok. IMO, it would be good if you say this using "FIXME: bla bla".

[Chris Dumez]

Created attachment 166885 [details]
Patch for landing

Take Gyuyoung's feedback into consideration.

[WebKit Review Bot]

Comment on attachment 166885 [details]
Patch for landing

Clearing flags on attachment: 166885

Committed r130285: <http://trac.webkit.org/changeset/130285>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.