Bug 98252 - Pair NDEBUG optioning in RefCountedBase.
Summary: Pair NDEBUG optioning in RefCountedBase.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 03:18 PDT by Kangil Han
Modified: 2012-10-03 23:21 PDT (History)
3 users (show)

See Also:

Attachments
patch (2.24 KB, patch)
2012-10-03 03:20 PDT, Kangil Han 		benjamin: review-
Details | Formatted Diff | Diff
patch (6.06 KB, patch)
2012-10-03 20:10 PDT, Kangil Han 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-10-03 03:18:02 PDT 
Fixed incomplete NDEBUG option implementation.
Comment 1 Kangil Han 2012-10-03 03:20:54 PDT 
Created attachment 166844 [details]
patch
Comment 2 Benjamin Poulain 2012-10-03 12:47:32 PDT 
Comment on attachment 166844 [details]
patch

Your patch is correct. But I think we are abusing NDEBUG here. I would like a new #define based on NDEBUG like we do in HashTable.

For example define CHECK_REF_COUNTED_LIFECYCLE if not NDEBUG.
Comment 3 Kangil Han 2012-10-03 20:10:09 PDT 
Created attachment 167027 [details]
patch

Done~
Comment 4 WebKit Review Bot 2012-10-03 23:21:47 PDT 
Comment on attachment 167027 [details]
patch

Clearing flags on attachment: 167027

Committed r130365: <http://trac.webkit.org/changeset/130365>
Comment 5 WebKit Review Bot 2012-10-03 23:21:50 PDT 
All reviewed patches have been landed.  Closing bug.