Bug 98249 - [EFL][WK2] Implement PageClientImpl::isViewVisible()
Summary: [EFL][WK2] Implement PageClientImpl::isViewVisible()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 02:56 PDT by Chris Dumez
Modified: 2012-10-04 16:51 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.24 KB, patch)
2012-10-03 02:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-03 02:56:56 PDT 
PageClientImpl::isViewVisible() is currently unimplemented for EFL port.

We should implement it as it allows for some painting optimizations.
Comment 1 Chris Dumez 2012-10-03 02:58:58 PDT 
Created attachment 166840 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-10-03 03:29:58 PDT 
Comment on attachment 166840 [details]
Patch

LGTM, I guess. Do we just want to reflect whether evas_object_{show,hide} has been called indeed?
Comment 3 Chris Dumez 2012-10-03 03:43:06 PDT 
(In reply to comment #2)
> (From update of attachment 166840 [details])
> LGTM, I guess. Do we just want to reflect whether evas_object_{show,hide} has been called indeed?

Yes.
Comment 4 WebKit Review Bot 2012-10-04 16:51:25 PDT 
Comment on attachment 166840 [details]
Patch

Clearing flags on attachment: 166840

Committed r130434: <http://trac.webkit.org/changeset/130434>
Comment 5 WebKit Review Bot 2012-10-04 16:51:29 PDT 
All reviewed patches have been landed.  Closing bug.