Bug 98247 – REGRESSION(130231): Causes 3 complex font test failures on EFL / Harfbuzz+Freetype

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Dominik Röttsches (drott)]

r130231 introduced 3 test failures on EFL which has Harfbuzz NG + Freetype enabled. I am attaching a test result difference here.

[Dominik Röttsches (drott)]

Created attachment 166836 [details]
Test Failures after r130231

Looks like at least one combined glyph for the apostroph over e in  "Lorém ipsum" is failing. The pixel results for the other two pass with failed hash but passed pixel difference under the threshold - text diff show small differences.

[Kenichi Ishibashi]

Created attachment 166837 [details]
Patch

[Kenichi Ishibashi]

(In reply to comment #2)
> Created an attachment (id=166837) [details]
> Patch

Dominik, Could you try the patch? I didn't compile it(I don't have efl port build environment).

[Kenichi Ishibashi]

Created attachment 166841 [details]
Fix missing resource unlock

[Dominik Röttsches (drott)]

Created attachment 166847 [details]
Patch

[Dominik Röttsches (drott)]

(In reply to comment #5)
> Created an attachment (id=166847) [details]
> Patch

Updated the patch - works for me (TM) and fixes the issue on EFL. I decorated it with Changelogs - ready for landing IMHO, LGTM.

[WebKit Review Bot]

Comment on attachment 166847 [details]
Patch

Rejecting attachment 166847 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
z 3.
patching file Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/efl/TestExpectations
Hunk #1 FAILED at 1496.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/efl/TestExpectations.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14256545

[Dominik Röttsches (drott)]

Created attachment 168223 [details]
Patch

[WebKit Review Bot]

Comment on attachment 168223 [details]
Patch

Clearing flags on attachment: 168223

Committed r131058: <http://trac.webkit.org/changeset/131058>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Appears to have broken EFL build:
/home/chris/unencrypted/WebKit/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp: In member function ‘bool WebCore::SimpleFontData::canRenderCombiningCharacterSequence(const UChar*, size_t) const’:
/home/chris/unencrypted/WebKit/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:184:36: error: ‘WTF::HashTableIterator<WTF::String, WTF::KeyValuePair<WTF::String, bool>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, bool> >, WTF::StringHash, WTF::HashMapValueTraits<WTF::HashTraits<WTF::String>, WTF::HashTraits<bool> >, WTF::HashTraits<WTF::String> >::ValueType’ has no member named ‘second’
/home/chris/unencrypted/WebKit/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:198:29: error: ‘WTF::HashTableIterator<WTF::String, WTF::KeyValuePair<WTF::String, bool>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, bool> >, WTF::StringHash, WTF::HashMapValueTraits<WTF::HashTraits<WTF::String>, WTF::HashTraits<bool> >, WTF::HashTraits<WTF::String> >::ValueType’ has no member named ‘second’
/home/chris/unencrypted/WebKit/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:201:32: error: ‘WTF::HashTableIterator<WTF::String, WTF::KeyValuePair<WTF::String, bool>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, bool> >, WTF::StringHash, WTF::HashMapValueTraits<WTF::HashTraits<WTF::String>, WTF::HashTraits<bool> >, WTF::HashTraits<WTF::String> >::ValueType’ has no member named ‘second’
/home/chris/unencrypted/WebKit/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:202:1: warning: control reaches end of non-void function [-Wreturn-type]
make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/freetype/SimpleFontDataFreeType.cpp.o] Error 1