Bug 98245 - Remove MemoryInstrumentation::addCollectionElements
Summary: Remove MemoryInstrumentation::addCollectionElements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 02:25 PDT by Yury Semikhatsky
Modified: 2012-10-03 03:12 PDT (History)
13 users (show)

See Also:

Attachments
Patch (7.45 KB, patch)
2012-10-03 02:27 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-10-03 02:25:26 PDT 
reportSequenceMemoryUsage which provides more generic mechanism for instrumenting iterable sequence should be used instead of MemoryInstrumentation::addCollectionElements.
Comment 1 Yury Semikhatsky 2012-10-03 02:27:59 PDT 
Created attachment 166833 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-10-03 02:35:49 PDT 
Comment on attachment 166833 [details]
Patch

lgtm
Comment 3 WebKit Review Bot 2012-10-03 03:11:58 PDT 
Comment on attachment 166833 [details]
Patch

Clearing flags on attachment: 166833

Committed r130272: <http://trac.webkit.org/changeset/130272>
Comment 4 WebKit Review Bot 2012-10-03 03:12:01 PDT 
All reviewed patches have been landed.  Closing bug.