Bug 98238 - [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness
Summary: [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 01:05 PDT by Chris Dumez
Modified: 2012-10-03 01:43 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2012-10-03 01:08 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-03 01:05:39 PDT 
TestRunner.setAlwaysAcceptCookies() can be called by tests to temporarily force acceptation of all cookies. However, we don't reset this setting in InjectedBundle::beginTesting() so it causes flakiness.
Comment 1 Chris Dumez 2012-10-03 01:08:05 PDT 
Created attachment 166823 [details]
Patch
Comment 2 Csaba Osztrogonác 2012-10-03 01:10:43 PDT 
Comment on attachment 166823 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2012-10-03 01:43:30 PDT 
Comment on attachment 166823 [details]
Patch

Clearing flags on attachment: 166823

Committed r130262: <http://trac.webkit.org/changeset/130262>
Comment 4 WebKit Review Bot 2012-10-03 01:43:34 PDT 
All reviewed patches have been landed.  Closing bug.