Bug 98212 – [WK2] Support all attributes of GeolocationPosition

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Benjamin Poulain]

We only support the 3 basic attributes.

[Benjamin Poulain]

Created attachment 166779 [details]
Patch

[WebKit Review Bot]

Attachment 166779 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
LayoutTests/platform/qt/TestExpectations:2739:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/qt/TestExpectations:2740:  Path does not exist.  [test/expectations] [5]
Total errors found: 2 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Benjamin Poulain]

Created attachment 166795 [details]
Patch

[WebKit Review Bot]

Attachment 166795 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
LayoutTests/platform/qt/TestExpectations:2739:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/qt/TestExpectations:2740:  Path does not exist.  [test/expectations] [5]
Total errors found: 2 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 166795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166795&action=review

> Source/WebKit2/Shared/WebGeolocationPosition.cpp:56
> +    encoder->encode(CoreIPC::In(timestamp, latitude, longitude, accuracy, canProvideAltitude, altitude, canProvideAltitudeAccuracy, altitudeAccuracy, canProvideHeading, heading, canProvideSpeed, speed));

Instead of adding the overload of CoreIPC::In(), can you just call encoder->encode multiple times.  That has become more idiomatic in our code.

> Source/WebKit2/Shared/WebGeolocationPosition.cpp:61
> +    return decoder->decode(CoreIPC::Out(data.timestamp, data.latitude, data.longitude, data.accuracy, data.canProvideAltitude, data.altitude, data.canProvideAltitudeAccuracy, data.altitudeAccuracy, data.canProvideHeading, data.heading, data.canProvideSpeed, data.speed));

Same here.

[Benjamin Poulain]

(In reply to comment #5)
> Instead of adding the overload of CoreIPC::In(), can you just call encoder->encode multiple times.  That has become more idiomatic in our code.

I know, I just find it a little silly to have to limit ourself to 10 args :)

[Benjamin Poulain]

Committed r130416: <http://trac.webkit.org/changeset/130416>

[Jessie Berlin]

*** Bug 94554 has been marked as a duplicate of this bug. ***