Bug 98211 - Do not swallow fatal messages in qt/DumpRenderTree
Summary: Do not swallow fatal messages in qt/DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-02 16:36 PDT by Peter Rybin
Modified: 2012-10-08 16:33 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.22 KB, patch)
2012-10-02 16:56 PDT, Peter Rybin
no flags Details | Formatted Diff | Diff
Patch (1.22 KB, patch)
2012-10-03 09:50 PDT, Peter Rybin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2012-10-02 16:36:47 PDT
Qt version of DumpRenderTree installs qt message handler that swallows fatal messages. Those messages might be highly valuable for basic troubleshooting.
Comment 1 Peter Rybin 2012-10-02 16:56:46 PDT
Created attachment 166778 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-10-03 09:27:09 PDT
Ossy, could you please have a look?
Comment 3 Peter Rybin 2012-10-03 09:50:22 PDT
Created attachment 166913 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-10-08 16:13:35 PDT
Comment on attachment 166913 [details]
Patch

rs=me.
Comment 5 WebKit Review Bot 2012-10-08 16:33:51 PDT
Comment on attachment 166913 [details]
Patch

Clearing flags on attachment: 166913

Committed r130703: <http://trac.webkit.org/changeset/130703>
Comment 6 WebKit Review Bot 2012-10-08 16:33:53 PDT
All reviewed patches have been landed.  Closing bug.