Bug 98207 – treeScopeOfParent doesn't return the TreeScope of the parent

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Dominic Mazzoni]

I think it should say "return parent->treeScope()", right? Looks like this should be better covered by tests.

static inline TreeScope* treeScopeOfParent(Node* node, ContainerNode* insertionPoint)
{
    if (Node* parent = node->parentNode())
        parent->treeScope();
    return insertionPoint->treeScope();
}

[Hayato Ito]

Created attachment 169358 [details]
Refactor.

[WebKit Review Bot]

Comment on attachment 169358 [details]
Refactor.

Rejecting attachment 169358 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14384890

[WebKit Review Bot]

Comment on attachment 169358 [details]
Refactor.

Attachment 169358 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14392954

New failing tests:
fast/dom/shadow/get-element-by-id-in-shadow-mutation.html

[Hayato Ito]

Created attachment 169374 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 169374 [details]
Patch for landing

Rejecting attachment 169374 [details] from commit-queue.

New failing tests:
fast/dom/shadow/get-element-by-id-in-shadow-mutation.html
Full output: http://queues.webkit.org/results/14459002

[Hayato Ito]

Created attachment 169400 [details]
Patch for landing

[Hayato Ito]

Let me retry. I've removed a treeScopeOfParent(),  which we don't need to call.

(In reply to comment #6)
> Created an attachment (id=169400) [details]
> Patch for landing

[WebKit Review Bot]

Comment on attachment 169400 [details]
Patch for landing

Clearing flags on attachment: 169400

Committed r131739: <http://trac.webkit.org/changeset/131739>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.