Bug 98201 - [Chromium] Page-scale-factor not applied to composited elements.
Summary: [Chromium] Page-scale-factor not applied to composited elements.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeff Timanus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-02 14:24 PDT by Jeff Timanus
Modified: 2013-04-15 08:51 PDT (History)
6 users (show)

See Also:

Attachments
Addition of test. (1.78 KB, patch)
2012-10-02 14:42 PDT, Jeff Timanus 		no flags Details | Formatted Diff | Diff
Test output from a local run. (51.18 KB, image/png)
2012-10-02 14:44 PDT, Jeff Timanus 		no flags Details
Address review comments. (1.85 KB, patch)
2012-10-02 14:51 PDT, Jeff Timanus 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Timanus 2012-10-02 14:24:19 PDT 
This issue is tracking the addition of a layout test that stresses page-scale-factor on composited elements.

See related comments on previous issue:  https://bugs.webkit.org/show_bug.cgi?id=95094#c53
Comment 1 Jeff Timanus 2012-10-02 14:42:11 PDT 
Created attachment 166753 [details]
Addition of test.
Comment 2 Jeff Timanus 2012-10-02 14:44:36 PDT 
Created attachment 166754 [details]
Test output from a local run.

Page-scale-factor is presently broken for composited elements, as shown by the output of this test.
Comment 3 Adrienne Walker 2012-10-02 14:46:25 PDT 
Comment on attachment 166753 [details]
Addition of test.

View in context: https://bugs.webkit.org/attachment.cgi?id=166753&action=review

Can you add:

if (window.testRunner)
    testRunner.dumpAsText(true);

...since we want a pixel test and don't care about layer tree here?

> LayoutTests/compositing/reflections/reflection-under-device-scale.html:28
> +  <p>Testing that composited layers behave properly when reflected with a page scale.</p>

Please, no text in a pixel test.  This can be an html comment.
Comment 4 Jeff Timanus 2012-10-02 14:51:58 PDT 
Created attachment 166756 [details]
Address review comments.
Comment 5 Dana Jansens 2012-10-02 15:05:01 PDT 
"composited elements" in this case means "layers with render surfaces" i think?
Comment 6 Jeff Timanus 2012-10-03 11:00:36 PDT 
(In reply to comment #5)
> "composited elements" in this case means "layers with render surfaces" i think?

Yes, that is the intent of my wording.

Also, I confirmed that your other patch (https://codereview.chromium.org/10915313/) corrects the output of this failing test.
Comment 7 Dana Jansens 2012-10-03 11:17:24 PDT 
Thanks for trying it out! :D