Bug 98196 - executive_unittest fails on Apple Windows bots but not when run locally
Summary: executive_unittest fails on Apple Windows bots but not when run locally
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-02 13:43 PDT by Roger Fong
Modified: 2017-07-18 08:29 PDT (History)
5 users (show)

See Also:

Attachments
patch (1.67 KB, patch)
2012-10-02 15:06 PDT, Roger Fong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2012-10-02 13:43:01 PDT 
py test fails on Apple Windows port.

[167/1585] webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process failed:
  Traceback (most recent call last):
    File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/common/system/executive_unittest.py", line 167, in serial_test_kill_process
      self.assertEqual(process.wait(), expected_exit_code)
  AssertionError: -6 != -9


Test fails only on bots but not when run locally. Unclear why.
In addition, sys.platform is "cygwin" not "win32"

Creating patch to make test more flexible to handle different behaviors from cygwin.
Comment 1 Roger Fong 2012-10-02 15:06:45 PDT 
Created attachment 166759 [details]
patch
Comment 2 Eric Seidel (no email) 2012-10-02 15:19:12 PDT 
Comment on attachment 166759 [details]
patch

LGTM.
Comment 3 WebKit Review Bot 2012-10-02 15:58:58 PDT 
Comment on attachment 166759 [details]
patch

Clearing flags on attachment: 166759

Committed r130223: <http://trac.webkit.org/changeset/130223>
Comment 4 WebKit Review Bot 2012-10-02 15:59:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Roger Fong 2012-10-02 15:59:47 PDT 
reopening to keep track of bug