Bug 98189 - [CSS Exclusions] Block children have incorrect offset when shape-inside element lays out below other elements
Summary: [CSS Exclusions] Block children have incorrect offset when shape-inside eleme...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
URL:
Keywords:
Depends on:
Blocks: 89256
  Show dependency tree / graph
 
Reported: 2012-10-02 12:20 PDT by Bear Travis
Modified: 2012-10-26 12:58 PDT (History)
3 users (show)

See Also:

Attachments
Page displaying the incorrect behavior (6.32 KB, text/html)
2012-10-02 12:20 PDT, Bear Travis 		no flags Details
Initial Patch (9.14 KB, patch)
2012-10-24 15:14 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
Adding shape-inside flag for tests (9.22 KB, patch)
2012-10-24 16:55 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2012-10-02 12:20:38 PDT 
Created attachment 166731 [details]
Page displaying the incorrect behavior

When two divs are present with the same shape inside, the last does not display its content inside the shape-inside content area.
Comment 1 Bear Travis 2012-10-24 13:42:11 PDT 
Altering title to address the more general bug. This would most often occur when an element with shape-inside had <p> children, and was not the first element in the document. The partial fix for this bug leaves bug 100284 in place, which will need to be fixed at a later date.
Comment 2 Bear Travis 2012-10-24 15:14:50 PDT 
Created attachment 170483 [details]
Initial Patch
Comment 3 Bear Travis 2012-10-24 16:55:11 PDT 
Created attachment 170516 [details]
Adding shape-inside flag for tests
Comment 4 Dirk Schulze 2012-10-26 12:33:24 PDT 
Comment on attachment 170516 [details]
Adding shape-inside flag for tests

LGTM. r=me.
Comment 5 WebKit Review Bot 2012-10-26 12:58:08 PDT 
Comment on attachment 170516 [details]
Adding shape-inside flag for tests

Clearing flags on attachment: 170516

Committed r132685: <http://trac.webkit.org/changeset/132685>
Comment 6 WebKit Review Bot 2012-10-26 12:58:12 PDT 
All reviewed patches have been landed.  Closing bug.