WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
98179
Allow LayerTreeHost subclasses to return a custom GraphicsLayerFactory
https://bugs.webkit.org/show_bug.cgi?id=98179
Summary
Allow LayerTreeHost subclasses to return a custom GraphicsLayerFactory
Anders Carlsson
Reported
2012-10-02 11:27:11 PDT
Allow LayerTreeHost subclasses to return a custom GraphicsLayerFactory
Attachments
Patch
(9.93 KB, patch)
2012-10-02 11:29 PDT
,
Anders Carlsson
no flags
Details
Formatted Diff
Diff
Patch
(9.94 KB, patch)
2012-10-02 12:30 PDT
,
Anders Carlsson
kling
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2012-10-02 11:29:54 PDT
Created
attachment 166720
[details]
Patch
WebKit Review Bot
Comment 2
2012-10-02 11:43:13 PDT
Attachment 166720
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3
2012-10-02 12:05:26 PDT
Comment on
attachment 166720
[details]
Patch
Attachment 166720
[details]
did not pass qt-wk2-ews (qt): Output:
http://queues.webkit.org/results/14130391
Anders Carlsson
Comment 4
2012-10-02 12:30:37 PDT
Created
attachment 166733
[details]
Patch
WebKit Review Bot
Comment 5
2012-10-02 12:33:56 PDT
Attachment 166733
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 6
2012-10-02 14:03:57 PDT
Committed
r130208
: <
http://trac.webkit.org/changeset/130208
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug