Bug 98163 - Web Inspector: "Load profile..." context menu item has to be shown only for left column with the list of profiles.
Summary: Web Inspector: "Load profile..." context menu item has to be shown only for l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-02 08:20 PDT by Ilya Tikhonovsky
Modified: 2012-10-03 01:33 PDT (History)
13 users (show)

See Also:

Attachments
Patch (4.67 KB, patch)
2012-10-02 09:39 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Patch (5.42 KB, patch)
2012-10-02 10:25 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-10-02 08:20:00 PDT 
EOM
Comment 1 Ilya Tikhonovsky 2012-10-02 09:39:55 PDT 
Created attachment 166700 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-10-02 10:25:23 PDT 
Created attachment 166708 [details]
Patch
Comment 3 Yury Semikhatsky 2012-10-02 23:30:34 PDT 
Comment on attachment 166708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166708&action=review

> Source/WebCore/inspector/front-end/ProfilesPanel.js:1253
> +        if (profile.canSaveToFile()) {

Should it be a test for heap snapshot profile type + canSaveToFile as otherwise it is a bit confusing that all the titles include "Heap Snapshot" ?
Comment 4 Ilya Tikhonovsky 2012-10-03 01:33:51 PDT 
Committed r130261: <http://trac.webkit.org/changeset/130261>