WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
98163
Web Inspector: "Load profile..." context menu item has to be shown only for left column with the list of profiles.
https://bugs.webkit.org/show_bug.cgi?id=98163
Summary
Web Inspector: "Load profile..." context menu item has to be shown only for l...
Ilya Tikhonovsky
Reported
2012-10-02 08:20:00 PDT
EOM
Attachments
Patch
(4.67 KB, patch)
2012-10-02 09:39 PDT
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
Patch
(5.42 KB, patch)
2012-10-02 10:25 PDT
,
Ilya Tikhonovsky
yurys
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2012-10-02 09:39:55 PDT
Created
attachment 166700
[details]
Patch
Ilya Tikhonovsky
Comment 2
2012-10-02 10:25:23 PDT
Created
attachment 166708
[details]
Patch
Yury Semikhatsky
Comment 3
2012-10-02 23:30:34 PDT
Comment on
attachment 166708
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=166708&action=review
> Source/WebCore/inspector/front-end/ProfilesPanel.js:1253 > + if (profile.canSaveToFile()) {
Should it be a test for heap snapshot profile type + canSaveToFile as otherwise it is a bit confusing that all the titles include "Heap Snapshot" ?
Ilya Tikhonovsky
Comment 4
2012-10-03 01:33:51 PDT
Committed
r130261
: <
http://trac.webkit.org/changeset/130261
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug