Bug 98157 - [soup] Timeout support crashes if request already sent
Summary: [soup] Timeout support crashes if request already sent
Status: RESOLVED DUPLICATE of bug 98055
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on:
Blocks: 74802
  Show dependency treegraph
 
Reported: 2012-10-02 07:31 PDT by Dominik Röttsches (drott)
Modified: 2012-10-03 02:21 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.13 KB, patch)
2012-10-02 12:26 PDT, Dominik Röttsches (drott)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-10-02 07:31:27 PDT
After writing more tests in bug 74802 I found an issue with cleanup for timeouts in ResourceHandleSoup.
If a request was already sent out, then the timeout timer expires we start clearing the ResourceHandle - which leads to a RefPtr !m_deletionHasBegun failure when the sendRequestCallback is called. As a solution, I propose to reuse the d->m_cancelled flag for that purpose, and only destroy the handle when one of the progress callbacks is called - as before.
Comment 1 Dominik Röttsches (drott) 2012-10-02 12:26:25 PDT
Created attachment 166732 [details]
Patch
Comment 2 Martin Robinson 2012-10-02 12:33:51 PDT
See also: https://bugs.webkit.org/show_bug.cgi?id=98055

Is this bug a duplicate?
Comment 3 Dominik Röttsches (drott) 2012-10-02 13:27:36 PDT
(In reply to comment #2)
> See also: https://bugs.webkit.org/show_bug.cgi?id=98055
> 
> Is this bug a duplicate?

Good catch, thanks.

*** This bug has been marked as a duplicate of bug 98055 ***