Bug 98150 - Web Inspector: NMI: switch to non intrusive instrumentation of ParsedURL
Summary: Web Inspector: NMI: switch to non intrusive instrumentation of ParsedURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-02 05:07 PDT by Ilya Tikhonovsky
Modified: 2012-10-04 22:56 PDT (History)
15 users (show)

See Also:

Attachments
Patch (15.18 KB, patch)
2012-10-02 05:14 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-10-02 05:07:54 PDT 
EOM
Comment 1 Ilya Tikhonovsky 2012-10-02 05:14:02 PDT 
Created attachment 166675 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-02 10:55:43 PDT 
Comment on attachment 166675 [details]
Patch

Clearing flags on attachment: 166675

Committed r130187: <http://trac.webkit.org/changeset/130187>
Comment 3 WebKit Review Bot 2012-10-02 10:55:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Benjamin Poulain 2012-10-04 17:28:32 PDT 
Guys, I really wish you #ifdef-ed WTFURL instead of making the build break even worse :( :( :(
Comment 5 Ilya Tikhonovsky 2012-10-04 22:44:21 PDT 
(In reply to comment #4)
> Guys, I really wish you #ifdef-ed WTFURL instead of making the build break even worse :( :( :(

It is not clear for me what do you mean.
Could you please point me to the build log with compile time error or to the configuration which was broken by the patch and I'll fix it.
Comment 6 Benjamin Poulain 2012-10-04 22:56:06 PDT 
> It is not clear for me what do you mean.
> Could you please point me to the build log with compile time error or to the configuration which was broken by the patch and I'll fix it.

WTFURL is not compiled by default.

+    info.addMember(arrayBuffer->spec());

arrayBuffer is not defined. spec() is not const.

It's fix, I'll upload everything this weekend.