Bug 98147 – Implement GraphicsSurface for Windows.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Zeno Albisser]

GraphicsSurface is used to share textures between the WebProcess and the UIProcess.
Currently there are only implementations for Mac and Linux/GLX.
We should make it available for Windows as well to allow for WebGL.
ANGLE can be used to map GL calls to DirectX.

[Zeno Albisser]

Created attachment 170348 [details]
Patch

[WebKit Review Bot]

Attachment 170348 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:351:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zeno Albisser]

Comment on attachment 170348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170348&action=review

>> Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:353
>> +             1,  1
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Indentation is like that on purpose.

[Kenneth Rohde Christiansen]

Comment on attachment 170348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170348&action=review

> Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:6
> +/*
> +
> + Copyright (C) 2012 Zeno Albisser <[e-mail]>
> +
> + This library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Library General Public

I think we normally have *'s here in the beginning of each line

> Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:79
> +        initShaderProgram();

webkit usually uses initialize*

> Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:488
> +    if (m_private)
> +        delete m_private;

That if is not needed

[Zeno Albisser]

(In reply to comment #4)
> I think we normally have *'s here in the beginning of each line
Depends on the licence header, we have both. I aligned with GraphicsContext3DQt.cpp, GraphicsSurface.h, GraphicsSurface.cpp and others.

> webkit usually uses initialize*
I'll fix that.

> > +    if (m_private)
> > +        delete m_private;
> That if is not needed
i'll fix that as well.

[Zeno Albisser]

Created attachment 170374 [details]
Patch

[WebKit Review Bot]

Attachment 170374 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:351:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kenneth Rohde Christiansen]

Comment on attachment 170374 [details]
Patch

r=me as this is at least a good start

[Zeno Albisser]

Comment on attachment 170374 [details]
Patch

Clearing flags on attachment: 170374

Committed r132343: <http://trac.webkit.org/changeset/132343>

[Zeno Albisser]

All reviewed patches have been landed.  Closing bug.

[Simon Hausmann]

Comment on attachment 170374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170374&action=review

> Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:3
> + Copyright (C) 2012 Zeno Albisser <[e-mail]>

Shouldn't this at least include Digia?

[Zeno Albisser]

> Shouldn't this at least include Digia?
I will add this the next time i touch the file.