Bug 98136 – [Qt][WK2] inspector/extensions/extensions-network.html times out

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit Qt

[Michael Brüning]

This test times out on Release builds and crashes/asserts on Debug builds. 

This is caused because WebPageProxy* WebInspectorProxy::platformCreateInspectorPage() is not implemented, so it will always fail until that is changed.

[Csaba Osztrogonác]

Unfortunately this test is skipped because of another bug - https://bugs.webkit.org/show_bug.cgi?id=89349

But you can add it to qt-5.0-wk2/TestExpectations too.

[Michael Brüning]

Created attachment 166654 [details]
Patch

[WebKit Review Bot]

Attachment 166654 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/qt-5.0-wk2/TestExpectations:1:  No port uses path LayoutTests/platform/qt-5.0-wk2/TestExpectations for test_expectations  [test/expectations] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Csaba Osztrogonác]

It seems you have to commit it manually because of buggy check-webkit-style

[Csaba Osztrogonác]

(In reply to comment #4)
> It seems you have to commit it manually because of buggy check-webkit-style

I filed a new bug report against check-webkit-style:
https://bugs.webkit.org/show_bug.cgi?id=98140

[Michael Brüning]

(In reply to comment #4)
> It seems you have to commit it manually because of buggy check-webkit-style

Okay, we'll just have to wait until I have my special committer super powers back then...

[Michael Brüning]

Committed r130173: <http://trac.webkit.org/changeset/130173>

[Csaba Osztrogonác]

The bug isn't fixed, only the skipping landed.