Bug 98135 - Web Inspector: fix front-end compilation
Summary: Web Inspector: fix front-end compilation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-02 03:20 PDT by Nikita Vasilyev
Modified: 2012-10-02 05:09 PDT (History)
11 users (show)

See Also:

Attachments
Fix (1.84 KB, patch)
2012-10-02 03:26 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Patch (14.79 KB, patch)
2012-10-02 04:59 PDT, Pavel Feldman 		vsevik: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2012-10-02 03:20:29 PDT 
The bug was introduced by https://bugs.webkit.org/show_bug.cgi?id=96763#c23

Patch to follow.
Comment 1 Nikita Vasilyev 2012-10-02 03:26:28 PDT 
Created attachment 166652 [details]
Fix
Comment 2 Pavel Feldman 2012-10-02 04:23:04 PDT 
Comment on attachment 166652 [details]
Fix

This change should also annotate callbacks as @param {function(Array.<string>, number=)} completionsReadyCallback
Comment 3 Pavel Feldman 2012-10-02 04:55:25 PDT 
Let me upload a bunch of fixes here
Comment 4 Pavel Feldman 2012-10-02 04:59:42 PDT 
Created attachment 166671 [details]
Patch
Comment 5 Vsevolod Vlasov 2012-10-02 05:06:15 PDT 
Comment on attachment 166671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166671&action=review

> Source/WebCore/inspector/InjectedScriptSource.js:978
> +     * @param {Node|undefined} node

Node= ?
Comment 6 Pavel Feldman 2012-10-02 05:09:34 PDT 
Committed r130154: <http://trac.webkit.org/changeset/130154>