WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
98135
Web Inspector: fix front-end compilation
https://bugs.webkit.org/show_bug.cgi?id=98135
Summary
Web Inspector: fix front-end compilation
Nikita Vasilyev
Reported
2012-10-02 03:20:29 PDT
The bug was introduced by
https://bugs.webkit.org/show_bug.cgi?id=96763#c23
Patch to follow.
Attachments
Fix
(1.84 KB, patch)
2012-10-02 03:26 PDT
,
Nikita Vasilyev
no flags
Details
Formatted Diff
Diff
Patch
(14.79 KB, patch)
2012-10-02 04:59 PDT
,
Pavel Feldman
vsevik
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1
2012-10-02 03:26:28 PDT
Created
attachment 166652
[details]
Fix
Pavel Feldman
Comment 2
2012-10-02 04:23:04 PDT
Comment on
attachment 166652
[details]
Fix This change should also annotate callbacks as @param {function(Array.<string>, number=)} completionsReadyCallback
Pavel Feldman
Comment 3
2012-10-02 04:55:25 PDT
Let me upload a bunch of fixes here
Pavel Feldman
Comment 4
2012-10-02 04:59:42 PDT
Created
attachment 166671
[details]
Patch
Vsevolod Vlasov
Comment 5
2012-10-02 05:06:15 PDT
Comment on
attachment 166671
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=166671&action=review
> Source/WebCore/inspector/InjectedScriptSource.js:978 > + * @param {Node|undefined} node
Node= ?
Pavel Feldman
Comment 6
2012-10-02 05:09:34 PDT
Committed
r130154
: <
http://trac.webkit.org/changeset/130154
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug