Bug 98134 - [Refactoring] StyleResolver::matchScopedAuthorRules() could be simpler
Summary: [Refactoring] StyleResolver::matchScopedAuthorRules() could be simpler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 97279
  Show dependency treegraph
 
Reported: 2012-10-02 03:20 PDT by Hajime Morrita
Modified: 2012-10-02 22:26 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.77 KB, patch)
2012-10-02 03:28 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch for landing (3.88 KB, patch)
2012-10-02 21:49 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-10-02 03:20:10 PDT
This is simple refactoring for preparation around style scope related changes.
Comment 1 Hajime Morrita 2012-10-02 03:28:03 PDT
Created attachment 166653 [details]
Patch
Comment 2 Hajime Morrita 2012-10-02 03:28:24 PDT
Dimitri, Sakamoto-san, could you take a look?
Comment 3 Build Bot 2012-10-02 05:55:54 PDT
Comment on attachment 166653 [details]
Patch

Attachment 166653 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14131254

New failing tests:
http/tests/workers/terminate-during-sync-operation.html
Comment 4 Dimitri Glazkov (Google) 2012-10-02 09:16:16 PDT
Comment on attachment 166653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166653&action=review

ok.

> Source/WebCore/css/StyleResolver.cpp:977
> +        if (documentScope ? !applyAuthorStyles : frame.m_authorStyleBoundsIndex != m_scopeStackParentBoundsIndex)

This is getting too terse :)
Comment 5 Hajime Morrita 2012-10-02 21:47:47 PDT
Comment on attachment 166653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166653&action=review

Hi Dimitri,
Thanks for taking a look! I'll land this after small tweak.

>> Source/WebCore/css/StyleResolver.cpp:977
>> +        if (documentScope ? !applyAuthorStyles : frame.m_authorStyleBoundsIndex != m_scopeStackParentBoundsIndex)
> 
> This is getting too terse :)

Well, will relax a bit more :-)
Comment 6 Hajime Morrita 2012-10-02 21:49:17 PDT
Created attachment 166806 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-10-02 22:25:57 PDT
Comment on attachment 166806 [details]
Patch for landing

Clearing flags on attachment: 166806

Committed r130249: <http://trac.webkit.org/changeset/130249>
Comment 8 WebKit Review Bot 2012-10-02 22:26:00 PDT
All reviewed patches have been landed.  Closing bug.