Bug 98121 – [EFL][WK2] Add setting to allow file access from file:// URLs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

We should add a setting to Ewk_Settings to that the browser can allow file access from file:// URLs. Such access is currently disallowed by default and makes testing with Minibrowser more complicated.

[Chris Dumez]

Created attachment 166624 [details]
Patch

[Chris Dumez]

Created attachment 166639 [details]
Patch

Fix bug title (add WK2 tag).

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 166639 [details]
Patch

Looks fine to me. I wonder if it is possible to check that actually accessing local URIs works/does not work in the API tests?

[Chris Dumez]

Comment on attachment 166639 [details]
Patch

Will take rakuco's feedback into consideration.

[Chris Dumez]

Created attachment 166660 [details]
Patch

Take rakuco's feedback into consideration.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 166660 [details]
Patch

LGTM.

[Dominik Röttsches (drott)]

Comment on attachment 166660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166660&action=review

> Source/WebKit2/UIProcess/API/efl/tests/resources/local_file_access.html:16
> +    document.title = "Frame NOT loaded";

I don't know the exact semantics of waitUntilTitleChangedTo() - is this document.title line needed?

> Source/WebKit2/UIProcess/API/efl/tests/resources/local_file_access.html:24
> +    setTimeout("checkFrameLoaded()", 300);

Could you get rid of the timeout by using a callback to parent from the loaded iframe?

[Chris Dumez]

Comment on attachment 166660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166660&action=review

>> Source/WebKit2/UIProcess/API/efl/tests/resources/local_file_access.html:16
>> +    document.title = "Frame NOT loaded";
> 
> I don't know the exact semantics of waitUntilTitleChangedTo() - is this document.title line needed?

Well, yes, it is needed. The unit tests are testing both cases (local frame is loaded, and local frame is NOT loaded). Therefore, I also need to specific title when the iframe is not loaded.

>> Source/WebKit2/UIProcess/API/efl/tests/resources/local_file_access.html:24
>> +    setTimeout("checkFrameLoaded()", 300);
> 
> Could you get rid of the timeout by using a callback to parent from the loaded iframe?

What if the iframe is not loaded? (which happens when we disallow local file access from file:// URLs).

[Dominik Röttsches (drott)]

(In reply to comment #8)

> What if the iframe is not loaded? (which happens when we disallow local file access from file:// URLs).

Yes, as discussed offline, it looks like then there wouldn't be a good way to detect the failure case without a timeout, in which case it's much easier to just have one timer for both cases. So, I am fine with leaving the timer there if there's no good way for both, success and load failure case.

[Laszlo Gombos]

Comment on attachment 166660 [details]
Patch

Looks good to me, r+.

[WebKit Review Bot]

Comment on attachment 166660 [details]
Patch

Clearing flags on attachment: 166660

Committed r130395: <http://trac.webkit.org/changeset/130395>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.