Bug 98111 - [chromium] Remove call to FinishAllRendering when in force-compositing-mode
Summary: [chromium] Remove call to FinishAllRendering when in force-compositing-mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vangelis Kokkevis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-01 21:31 PDT by Vangelis Kokkevis
Modified: 2012-10-02 09:45 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.79 KB, patch)
2012-10-01 22:01 PDT, Vangelis Kokkevis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2012-10-01 21:31:41 PDT
Calling FinishAllRendering when setIsAcceleratedCompositingActive(false) is called is not necessary when we don't switch between accelerated and software compositing. FinishAllRendering make a synchronous glFinish call that blocks the renderer for tens of milliseconds and should be avoided when possible.
Comment 1 Vangelis Kokkevis 2012-10-01 22:01:43 PDT
Created attachment 166604 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-02 09:45:12 PDT
Comment on attachment 166604 [details]
Patch

Clearing flags on attachment: 166604

Committed r130178: <http://trac.webkit.org/changeset/130178>
Comment 3 WebKit Review Bot 2012-10-02 09:45:14 PDT
All reviewed patches have been landed.  Closing bug.