Bug 98104 - Week specifiers defined in DateTimeFormat class are wrong.
Summary: Week specifiers defined in DateTimeFormat class are wrong.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 97877 98120
  Show dependency treegraph
 
Reported: 2012-10-01 19:01 PDT by yosin
Modified: 2012-10-02 19:03 PDT (History)
5 users (show)

See Also:


Attachments
Patch 1 (4.14 KB, patch)
2012-10-01 19:29 PDT, yosin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-10-01 19:01:43 PDT
Week of year and week of month must be:

week of year = 'w' (lower case'w')
week of month = 'W' (upper case 'W')
Comment 1 yosin 2012-10-01 19:29:51 PDT
Created attachment 166591 [details]
Patch 1
Comment 2 yosin 2012-10-01 19:30:40 PDT
Comment on attachment 166591 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-10-01 20:21:46 PDT
Comment on attachment 166591 [details]
Patch 1

ok
Comment 4 yosin 2012-10-01 21:22:38 PDT
Comment on attachment 166591 [details]
Patch 1

Clearing flags on attachment: 166591

Committed r130116: <http://trac.webkit.org/changeset/130116>
Comment 5 yosin 2012-10-01 21:22:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 yosin 2012-10-01 23:20:01 PDT
(In reply to comment #6)
> This caused two webkit_unit_test failures. Maybe the tests need updating?
> 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_unit_tests&tests=DateTimeFormatTest.SingleUpperCaseCharacter%2CDateTimeFormatTest.SingleLowerCaseCharacter

Yes, I field a bug 98120, for updating tests.
Comment 8 Darin Adler 2012-10-02 09:22:40 PDT
Comment on attachment 166591 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=166591&action=review

> Source/WebCore/ChangeLog:12
> +        No new tests. Following existing tests cover this change:

Why no new tests? Is this really not a testable change?
Comment 9 yosin 2012-10-02 19:03:23 PDT
(In reply to comment #8)
> (From update of attachment 166591 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166591&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        No new tests. Following existing tests cover this change:
> 
> Why no new tests? Is this really not a testable change?
This is testable change. There are layoyut tests listed in ChangeLog and webkit_unit_tests, sorry I forgot to include this in this patch, in bug 98120.