Bug 98103 - Move tests for calendar picker to platform/chromium/fast/forms/calendar-picker/
Summary: Move tests for calendar picker to platform/chromium/fast/forms/calendar-picker/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-01 18:46 PDT by Kent Tamura
Modified: 2012-10-16 18:18 PDT (History)
4 users (show)

See Also:

Attachments
Patch (184.23 KB, patch)
2012-10-16 02:11 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch 2 (185.06 KB, patch)
2012-10-16 03:06 PDT, Kent Tamura 		yutak: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-10-01 18:46:02 PDT 
Move tests for calendar picker to fast/forms/calendar-picker/ because of ease of skipping and we're going to support non-date types in the calendar picker.
Comment 1 Kent Tamura 2012-10-16 00:33:46 PDT 
Also, we're not sure the calendar picker code will be used on other platforms.
Comment 2 Kent Tamura 2012-10-16 02:11:25 PDT 
Created attachment 168895 [details]
Patch
Comment 3 WebKit Review Bot 2012-10-16 03:01:58 PDT 
Comment on attachment 168895 [details]
Patch

Attachment 168895 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14387100

New failing tests:
platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html
Comment 4 Kent Tamura 2012-10-16 03:06:04 PDT 
Created attachment 168906 [details]
Patch 2

Fix page-poup-adjust-rect.html
Comment 5 Yuta Kitamura 2012-10-16 08:31:36 PDT 
Comment on attachment 168906 [details]
Patch 2

Rubber-stamped. I see image results are not correctly shown in the code review screen (some say "Image lacks a checksum"). I'm not sure why they are shown like this, but please make sure the images are correctly moved before landing.
Comment 6 Kent Tamura 2012-10-16 18:18:30 PDT 
Committed r131538: <http://trac.webkit.org/changeset/131538>