Bug 98097 - Attempt to simplify IPC message dispatching logic in WebKit2
Summary: Attempt to simplify IPC message dispatching logic in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-01 17:07 PDT by Anders Carlsson
Modified: 2012-10-03 00:10 PDT (History)
13 users (show)

See Also:

Attachments
Patch (27.55 KB, patch)
2012-10-01 17:13 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (28.11 KB, patch)
2012-10-02 10:53 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (28.11 KB, patch)
2012-10-02 12:59 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (28.09 KB, patch)
2012-10-02 13:44 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-10-01 17:07:12 PDT 
Attempt to simplify IPC message dispatching logic in WebKit2
Comment 1 Anders Carlsson 2012-10-01 17:13:56 PDT 
Created attachment 166577 [details]
Patch
Comment 2 kov's GTK+ EWS bot 2012-10-01 18:30:18 PDT 
Comment on attachment 166577 [details]
Patch

Attachment 166577 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14130085
Comment 3 kov's GTK+ EWS bot 2012-10-01 18:35:03 PDT 
Comment on attachment 166577 [details]
Patch

Attachment 166577 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14124154
Comment 4 Anders Carlsson 2012-10-02 10:53:18 PDT 
Created attachment 166713 [details]
Patch
Comment 5 Anders Carlsson 2012-10-02 12:35:23 PDT 
Not sure why the GTK+ bot isn't finding the new files - I'm going to land this anyway and see if it breaks the build.
Comment 6 Anders Carlsson 2012-10-02 12:59:57 PDT 
Created attachment 166737 [details]
Patch
Comment 7 Anders Carlsson 2012-10-02 13:00:19 PDT 
(In reply to comment #5)
> Not sure why the GTK+ bot isn't finding the new files - I'm going to land this anyway and see if it breaks the build.

Looks like i used spaces instead of tabs in the Makefile. Trying again.
Comment 8 Anders Carlsson 2012-10-02 13:44:39 PDT 
Created attachment 166743 [details]
Patch
Comment 9 Anders Carlsson 2012-10-02 14:02:26 PDT 
Committed r130207: <http://trac.webkit.org/changeset/130207>
Comment 10 Zan Dobersek 2012-10-03 00:10:37 PDT 
(In reply to comment #7)
> (In reply to comment #5)
> > Not sure why the GTK+ bot isn't finding the new files - I'm going to land this anyway and see if it breaks the build.
> 
> Looks like i used spaces instead of tabs in the Makefile. Trying again.

It still broke the build, but fixed in r130257.
http://trac.webkit.org/changeset/130257