Bug 98094 - REGRESSION (r129738): Suggestion picker label is placed in the wrong location
Summary: REGRESSION (r129738): Suggestion picker label is placed in the wrong location
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-01 16:51 PDT by Keishi Hattori
Modified: 2012-10-02 23:24 PDT (History)
3 users (show)

See Also:

Attachments
Patch (33.40 KB, patch)
2012-10-01 17:01 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (34.39 KB, patch)
2012-10-02 04:42 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (35.95 KB, patch)
2012-10-02 22:15 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-10-01 16:51:36 PDT 
I was confused and somehow thought that rtl reverses padding left/right.
Comment 1 Keishi Hattori 2012-10-01 17:01:35 PDT 
Created attachment 166575 [details]
Patch
Comment 2 Kent Tamura 2012-10-01 17:15:12 PDT 
Comment on attachment 166575 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-10-01 18:02:58 PDT 
Comment on attachment 166575 [details]
Patch

Attachment 166575 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14123136

New failing tests:
platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html
Comment 4 Keishi Hattori 2012-10-02 04:42:29 PDT 
Created attachment 166667 [details]
Patch
Comment 5 WebKit Review Bot 2012-10-02 05:40:44 PDT 
Comment on attachment 166667 [details]
Patch

Rejecting attachment 166667 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
m/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
49>At revision 63.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Total errors found: 0 in 1 files

Full output: http://queues.webkit.org/results/14118475
Comment 6 Keishi Hattori 2012-10-02 22:15:17 PDT 
Created attachment 166807 [details]
Patch
Comment 7 WebKit Review Bot 2012-10-02 23:24:39 PDT 
Comment on attachment 166807 [details]
Patch

Clearing flags on attachment: 166807

Committed r130254: <http://trac.webkit.org/changeset/130254>
Comment 8 WebKit Review Bot 2012-10-02 23:24:42 PDT 
All reviewed patches have been landed.  Closing bug.