RESOLVED FIXED 98082
Add new GraphicsLayer::create overload to all ports 
https://bugs.webkit.org/show_bug.cgi?id=98082
Summary Add new GraphicsLayer::create overload to all ports
Anders Carlsson
Reported 2012-10-01 15:36:33 PDT
Add new GraphicsLayer::create overload to all ports
Attachments
Patch (5.23 KB, patch)
2012-10-01 15:38 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (7.84 KB, patch)
2012-10-01 16:21 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (7.84 KB, patch)
2012-10-01 16:42 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (7.84 KB, patch)
2012-10-01 16:54 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (8.11 KB, patch)
2012-10-01 16:58 PDT, Anders Carlsson 		kling: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-10-01 15:38:10 PDT
Created attachment 166561 [details] Patch
James Robinson
Comment 2 2012-10-01 16:01:58 PDT
Can I ask what this is for?
Early Warning System Bot
Comment 3 2012-10-01 16:02:46 PDT
Comment on attachment 166561 [details] Patch Attachment 166561 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14089954
Early Warning System Bot
Comment 4 2012-10-01 16:10:58 PDT
Comment on attachment 166561 [details] Patch Attachment 166561 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14088952
Build Bot
Comment 5 2012-10-01 16:21:03 PDT
Comment on attachment 166561 [details] Patch Attachment 166561 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14131006 New failing tests: svg/animations/smil-leak-dynamically-added-element-instances.svg
Anders Carlsson
Comment 6 2012-10-01 16:21:25 PDT
Created attachment 166568 [details] Patch
Early Warning System Bot
Comment 7 2012-10-01 16:37:46 PDT
Comment on attachment 166568 [details] Patch Attachment 166568 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14118258
Anders Carlsson
Comment 8 2012-10-01 16:42:54 PDT
Created attachment 166570 [details] Patch
Anders Carlsson
Comment 9 2012-10-01 16:54:14 PDT
Created attachment 166573 [details] Patch
Anders Carlsson
Comment 10 2012-10-01 16:58:55 PDT
Created attachment 166574 [details] Patch
Build Bot
Comment 11 2012-10-01 18:54:08 PDT
Comment on attachment 166574 [details] Patch Attachment 166574 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14118298 New failing tests: http/tests/workers/terminate-during-sync-operation.html
Anders Carlsson
Comment 12 2012-10-02 10:36:50 PDT
(In reply to comment #2) > Can I ask what this is for? Sure, it's to make it easier for ports to change the type of layers created on a per page basis. In WebKit2 it can be used to get rid of the setGraphicsLayerFactory code that the Qt port uses. We can also use it for experimenting with UI process side compositing.
Andreas Kling
Comment 13 2012-10-02 10:47:24 PDT
Comment on attachment 166574 [details] Patch r=me with non-herpderp ChangeLog.
Anders Carlsson
Comment 14 2012-10-02 10:50:44 PDT
Committed r130185: <http://trac.webkit.org/changeset/130185>
Note You need to log in before you can comment on or make changes to this bug.