Bug 98080 - Address a FIXME in JSArray::sort
Summary: Address a FIXME in JSArray::sort
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Keywords: InRadar
Depends on:
Reported: 2012-10-01 15:18 PDT by Filip Pizlo
Modified: 2017-04-13 08:49 PDT (History)
8 users (show)

See Also:

the patch (14.82 KB, patch)
2012-10-01 15:37 PDT, Filip Pizlo
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-10-01 15:18:57 PDT
And get rid of fast sorting of sparse maps.  Patch forthcoming.
Comment 1 Filip Pizlo 2012-10-01 15:37:12 PDT
Created attachment 166560 [details]
the patch
Comment 2 WebKit Review Bot 2012-10-01 15:38:59 PDT
Attachment 166560 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/runtime/JSArray.cpp:873:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 10 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2012-10-01 18:05:37 PDT
Landed in http://trac.webkit.org/changeset/130102
Comment 4 Brent Fulgham 2017-04-13 08:47:46 PDT