NEW 98077
[WK2] Wait until scrolling thread catches up to dump results 
https://bugs.webkit.org/show_bug.cgi?id=98077
Summary [WK2] Wait until scrolling thread catches up to dump results
Tim Horton
Reported 2012-10-01 14:54:10 PDT
This patch isn't done yet, but I'm attaching it here anyway. We need to wait until the scrolling thread has caught up (with dispatchAfterEnsuringUpdatedScrollPosition) until WKTR dumps results, so that we get the final state of the page.
Attachments
patch (6.36 KB, patch)
2012-10-01 15:06 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (5.47 KB, patch)
2012-10-23 16:19 PDT, Simon Fraser (smfr) 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2012-10-01 15:06:04 PDT
Created attachment 166554 [details] patch
WebKit Review Bot
Comment 2 2012-10-01 23:30:21 PDT
Attachment 166554 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/WebProcess/InjectedBundle/A..." exit_code: 1 Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:348: Extra space before ( in function call [whitespace/parens] [4] Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:927: Missing space before { [whitespace/braces] [5] Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:934: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:82: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2012-10-01 23:42:53 PDT
Comment on attachment 166554 [details] patch Attachment 166554 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14131133
Early Warning System Bot
Comment 4 2012-10-01 23:43:50 PDT
Comment on attachment 166554 [details] patch Attachment 166554 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14123223
Gyuyoung Kim
Comment 5 2012-10-01 23:55:16 PDT
Comment on attachment 166554 [details] patch Attachment 166554 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14114564
Simon Fraser (smfr)
Comment 6 2012-10-23 16:19:54 PDT
Created attachment 170263 [details] Patch
Simon Fraser (smfr)
Comment 7 2012-10-23 16:20:26 PDT
Comment on attachment 170263 [details] Patch Not for review. This still doesn't work with layerTreeAsText() because that runs before scrolling is done.
WebKit Review Bot
Comment 8 2012-10-23 16:24:21 PDT
Attachment 170263 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:348: Extra space before ( in function call [whitespace/parens] [4] Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:1887: Missing space before { [whitespace/braces] [5] Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:82: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 9 2012-10-23 16:40:44 PDT
Comment on attachment 170263 [details] Patch Attachment 170263 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14525148
EFL EWS Bot
Comment 10 2012-10-23 18:18:46 PDT
Comment on attachment 170263 [details] Patch Attachment 170263 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14520315
Early Warning System Bot
Comment 11 2012-10-23 21:55:21 PDT
Comment on attachment 170263 [details] Patch Attachment 170263 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14571001
Note You need to log in before you can comment on or make changes to this bug.