Bug 98076 - baseline flexitem aligment in columns incorrect when writing mode is orthogonal
Summary: baseline flexitem aligment in columns incorrect when writing mode is orthogonal
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: KyungTae Kim
URL: http://plexode.com/u/#AH)5(v42G%22E9(...
Keywords: InRadar
Depends on:
Blocks: 62048
  Show dependency treegraph
 
Reported: 2012-10-01 14:53 PDT by Tony Chang
Modified: 2016-12-15 16:26 PST (History)
10 users (show)

See Also:


Attachments
Patch (8.87 KB, patch)
2013-05-06 04:03 PDT, KyungTae Kim
beidson: review-
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (522.58 KB, application/zip)
2013-05-06 05:11 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (503.29 KB, application/zip)
2013-05-06 06:07 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (520.01 KB, application/zip)
2013-05-06 06:51 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-10-01 14:53:57 PDT
Test case in URL.

We try to compute the ascent of the vertical text, but we get -1 because firstLineBoxBaseline returns -1 when we're at a writing mode root.  For flexbox, we actually want the baseline even in the orthogonal case.
Comment 1 KyungTae Kim 2013-04-22 04:10:30 PDT
Is there a plan for fixing this bug?
I made a patch for fixing this. Can I upload that patch on here?
Comment 2 KyungTae Kim 2013-05-06 04:03:31 PDT
Created attachment 200651 [details]
Patch
Comment 3 Build Bot 2013-05-06 05:11:33 PDT
Comment on attachment 200651 [details]
Patch

Attachment 200651 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/300061

New failing tests:
css3/flexbox/flex-align-orthogonal-writing-mode.html
Comment 4 Build Bot 2013-05-06 05:11:34 PDT
Created attachment 200660 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.2
Comment 5 Build Bot 2013-05-06 06:07:09 PDT
Comment on attachment 200651 [details]
Patch

Attachment 200651 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/336053

New failing tests:
css3/flexbox/flex-align-orthogonal-writing-mode.html
Comment 6 Build Bot 2013-05-06 06:07:12 PDT
Created attachment 200663 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.2
Comment 7 Build Bot 2013-05-06 06:51:13 PDT
Comment on attachment 200651 [details]
Patch

Attachment 200651 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/340026

New failing tests:
css3/flexbox/flex-align-orthogonal-writing-mode.html
Comment 8 Build Bot 2013-05-06 06:51:15 PDT
Created attachment 200665 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 9 Brady Eidson 2016-05-24 21:38:18 PDT
Comment on attachment 200651 [details]
Patch

r- to clear stale patches from the review queue
Comment 10 Jon Lee 2016-12-15 16:26:27 PST
<rdar://problem/29695096>