Bug 98074 - Update main frame scroll position immediately for programmatic scrolls
Summary: Update main frame scroll position immediately for programmatic scrolls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 97287
  Show dependency tree / graph
 
Reported: 2012-10-01 14:46 PDT by Tim Horton
Modified: 2012-10-25 15:10 PDT (History)
7 users (show)

See Also:

Attachments
patch (2.72 KB, patch)
2012-10-01 14:50 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-10-01 14:46:10 PDT 
http://trac.webkit.org/changeset/115681 disabled this because it caused brokenness with user scrolls, however, we should be able to immediately commit programmatic scrolls. This will aid in running the layout tests with tiled drawing on, as many of the tests depend on the scroll position being updated immediately after a scrollTo or scrollBy.
Comment 1 Tim Horton 2012-10-01 14:50:43 PDT 
Created attachment 166551 [details]
patch
Comment 2 Beth Dakin 2012-10-02 12:14:13 PDT 
I'm wondering if this patch makes this code that Brady added recently totally unnecessary:

http://trac.webkit.org/changeset/129652
Comment 3 Simon Fraser (smfr) 2012-10-23 20:40:03 PDT 
It might do, yes.
Comment 4 Simon Fraser (smfr) 2012-10-23 20:40:28 PDT 
We need this change to make scrollTo() followed by layerTreeAsText() do the right thing in tests.
Comment 5 Tim Horton 2012-10-24 16:37:39 PDT 
I'm going to land this, then investigate rolling out Brady's change if we don't need it anymore.
Comment 6 Tim Horton 2012-10-24 16:41:37 PDT 
(In reply to comment #5)
> I'm going to land this, then investigate rolling out Brady's change if we don't need it anymore.

Ergh, I didn't update the changelog after merging the change. Oh, well.

http://trac.webkit.org/changeset/132422
Comment 7 Tim Horton 2012-10-25 15:10:00 PDT 
http://trac.webkit.org/changeset/115681 should have been warning enough... this broke the Find overlay again :\