Bug 98058 - Consolidate more MutationObserverRegistration logic in Node
Summary: Consolidate more MutationObserverRegistration logic in Node
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-01 11:59 PDT by Adam Klein
Modified: 2012-10-01 13:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.78 KB, patch)
2012-10-01 12:06 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Patch for landing (7.69 KB, patch)
2012-10-01 12:31 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2012-10-01 11:59:51 PDT 
Consolidate more MutationObserverRegistration logic in Node
Comment 1 Adam Klein 2012-10-01 12:06:55 PDT 
Created attachment 166520 [details]
Patch
Comment 2 Ryosuke Niwa 2012-10-01 12:12:23 PDT 
Comment on attachment 166520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166520&action=review

> Source/WebCore/ChangeLog:12
> +        This patch inverts that behavior so that there's no need to return the

I like it better without "inverts that behavior". It confused me.
Comment 3 Ryosuke Niwa 2012-10-01 12:13:22 PDT 
Comment on attachment 166520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166520&action=review

> Source/WebCore/dom/Node.cpp:2484
>      Vector<OwnPtr<MutationObserverRegistration> >* registry = ensureRareData()->ensureMutationObserverRegistry();

On a completely unrelated note, we need to invent a variant of HashMap that behaves like Vector when the map is small.
Comment 4 Adam Klein 2012-10-01 12:31:48 PDT 
Created attachment 166527 [details]
Patch for landing
Comment 5 Adam Klein 2012-10-01 12:32:17 PDT 
Comment on attachment 166520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166520&action=review

>> Source/WebCore/dom/Node.cpp:2484
>>      Vector<OwnPtr<MutationObserverRegistration> >* registry = ensureRareData()->ensureMutationObserverRegistry();
> 
> On a completely unrelated note, we need to invent a variant of HashMap that behaves like Vector when the map is small.

Definitely, there are several places recently where I've wanted something like that.
Comment 6 WebKit Review Bot 2012-10-01 13:11:54 PDT 
Comment on attachment 166527 [details]
Patch for landing

Clearing flags on attachment: 166527

Committed r130069: <http://trac.webkit.org/changeset/130069>
Comment 7 WebKit Review Bot 2012-10-01 13:11:57 PDT 
All reviewed patches have been landed.  Closing bug.