Bug 98044 - Enable ENCRYPTED_MEDIA support on Mac.
Summary: Enable ENCRYPTED_MEDIA support on Mac.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks: 98090
  Show dependency tree / graph
 
Reported: 2012-10-01 09:50 PDT by Jer Noble
Modified: 2012-10-12 11:08 PDT (History)
7 users (show)

See Also:

Attachments
Patch (37.54 KB, patch)
2012-10-01 10:14 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (37.58 KB, patch)
2012-10-01 11:18 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (50.11 KB, patch)
2012-10-05 16:21 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (62.94 KB, patch)
2012-10-10 17:42 PDT, Jer Noble 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-10-01 09:50:16 PDT 
Enable ENCRYPTED_MEDIA support on Mac.
Comment 1 Jer Noble 2012-10-01 10:14:47 PDT 
Created attachment 166497 [details]
Patch
Comment 2 Build Bot 2012-10-01 10:57:31 PDT 
Comment on attachment 166497 [details]
Patch

Attachment 166497 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14086859
Comment 3 Jer Noble 2012-10-01 11:18:29 PDT 
Created attachment 166509 [details]
Patch

Wrap MediaPlayerPrivateAVFoundationObjC::extendedSupportsType() in #if ENABLE(ENCRYPTED_MEDIA).
Comment 4 WebKit Review Bot 2012-10-01 14:53:08 PDT 
Comment on attachment 166509 [details]
Patch

Attachment 166509 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14080988

New failing tests:
fast/events/constructors/media-key-event-constructor.html
Comment 5 Jer Noble 2012-10-05 16:21:14 PDT 
Created attachment 167408 [details]
Patch

Add expected results for the mac platform.
Comment 6 WebKit Review Bot 2012-10-05 18:24:43 PDT 
Comment on attachment 167408 [details]
Patch

Attachment 167408 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14168943

New failing tests:
fast/events/constructors/media-key-event-constructor.html
Comment 7 Jer Noble 2012-10-10 17:42:39 PDT 
Created attachment 168105 [details]
Patch

Copied generic expected results to chplatform/chromium due to chromium results search order.
Comment 8 Anders Carlsson 2012-10-11 15:44:19 PDT 
Comment on attachment 168105 [details]
Patch

Id -> ID everywhere. Looks great otherwise!
Comment 9 Jer Noble 2012-10-12 10:48:38 PDT 
Unfortunately "sessionId" with its capitalization is part of the spec, so there's not much that can be done there.  However, all the other instances of Id will be changed to ID.  Thanks!
Comment 10 Jer Noble 2012-10-12 11:08:37 PDT 
Committed r131201: <http://trac.webkit.org/changeset/131201>