Bug 98039 - [webkitpy] Detect the multiple names of the wdiff binary in the Port class.
Summary: [webkitpy] Detect the multiple names of the wdiff binary in the Port class.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-01 09:06 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-10-01 12:22 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2012-10-01 09:24 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Patch for landing (3.17 KB, patch)
2012-10-01 12:19 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-10-01 09:06:02 PDT 
[webkitpy] Detect the multiple names of the wdiff binary in the Port class.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-10-01 09:24:10 PDT 
Created attachment 166491 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-10-01 09:27:19 PDT 
Comment on attachment 166491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166491&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:1234
> +        for path in ("/usr/bin/wdiff", "/usr/bin/dwdiff"):

Ideally, we should just check for 'wdiff' and 'dwdiff' to be able to also remove the implementation in chromium_mac.py, but I couldn't think of a portable way of getting a full path from that.
Comment 3 Dirk Pranke 2012-10-01 11:28:50 PDT 
Comment on attachment 166491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166491&action=review

>> Tools/Scripts/webkitpy/layout_tests/port/base.py:1234
>> +        for path in ("/usr/bin/wdiff", "/usr/bin/dwdiff"):
> 
> Ideally, we should just check for 'wdiff' and 'dwdiff' to be able to also remove the implementation in chromium_mac.py, but I couldn't think of a portable way of getting a full path from that.

perhaps we should have an is_in_the_path() abstraction somewhere that we can reuse for things like this ...
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-10-01 12:19:33 PDT 
Created attachment 166522 [details]
Patch for landing
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-10-01 12:22:11 PDT 
Committed r130065: <http://trac.webkit.org/changeset/130065>