We need to add more tests for calendar picker
Created attachment 166485 [details] Patch
Comment on attachment 166485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166485&action=review ok. > LayoutTests/fast/forms/date/calendar-picker-mouse-operations.html:79 > +function cumulativeOffset(element) { > + var x = 0; > + var y = 0; > + var parentFrame = element.ownerDocument.defaultView.frameElement; > + if (parentFrame) { > + var parentFrameOffset = cumulativeOffset(parentFrame); > + x = parentFrameOffset[0]; > + y = parentFrameOffset[1]; > + } > + if (element.parentNode) { > + do { > + x += element.offsetLeft || 0; > + y += element.offsetTop || 0; > + element = element.offsetParent; > + } while (element); > + } > + return [x, y]; > +} > + > +function hoverOverElement(element) { > + var offset = cumulativeOffset(element); > + var centerX = offset[0] + element.offsetWidth / 2; > + var centerY = offset[1] + element.offsetHeight / 2; > + eventSender.mouseMoveTo(centerX, centerY); > +} > + > +function clickElement(element) { I remember another test has these functions. Don't you share them?
Created attachment 166589 [details] Patch
(In reply to comment #2) > I remember another test has these functions. Don't you share them? Added these three functions for fast/forms/resources/common.js and used it in date-suggestion-picker-mouse-operations.html
Comment on attachment 166589 [details] Patch Clearing flags on attachment: 166589 Committed r130111: <http://trac.webkit.org/changeset/130111>
All reviewed patches have been landed. Closing bug.