Bug 98013 - Fix SVN mirror handling for the first build
Summary: Fix SVN mirror handling for the first build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on: 85887
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-01 04:18 PDT by Csaba Osztrogonác
Modified: 2014-02-06 08:04 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-10-01 04:18:27 PDT 
The "wating for SVN server" buildstep runs before the SVN buildstep.
( It is correct, because Tools/BuildSlaveSupport/wait-for-SVN-server.py
is to wait until the SVN mirror is in sync with svn.webkit.org. )

But unfortunately we can't run Tools/BuildSlaveSupport/wait-for-SVN-server.py
after a broken svn buildtep or for the first build of a new master, because
Tools/BuildSlaveSupport/wait-for-SVN-server.py doesn't exist at all.

We can solve this problem with downloading wait-for-SVN-server.py before running it:
curl https://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/wait-for-SVN-server.py?format=txt -o Tools/BuildSlaveSupport/wait-for-SVN-server.py --create-dirs

It isn't the best fix ... Downloading this script always is absolutely unnecessary.
But checking the existance of this file from master.cfg isn't trivial.
process.buildstep.BuildStep.FileExists does a similar thing, but it isn't good for us:
http://buildbot.net/buildbot/docs/0.8.5/reference/buildbot.steps.slave.FileExists-class.html
Comment 1 Csaba Osztrogonác 2014-02-06 08:04:54 PST 
Fixed by https://trac.webkit.org/changeset/163372
and https://trac.webkit.org/changeset/163441