Bug 97988 - Crash on FrameTree::scopedChildCount()
Summary: Crash on FrameTree::scopedChildCount()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-30 19:02 PDT by Hajime Morrita
Modified: 2012-09-30 22:56 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.23 KB, patch)
2012-09-30 19:06 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (2.39 KB, patch)
2012-09-30 21:46 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-09-30 19:02:04 PDT
This upstreams http://code.google.com/p/chromium/issues/detail?id=131646
Comment 1 Hajime Morrita 2012-09-30 19:06:40 PDT
Created attachment 166398 [details]
Patch
Comment 2 Kent Tamura 2012-09-30 20:16:41 PDT
Comment on attachment 166398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166398&action=review

> Source/WebCore/page/FrameTree.cpp:211
> +    Document* document = m_thisFrame->document();
> +    if (!document)
> +        return 0;
> +    return scopedChild(index, document);

Can you make scopedChild(unsigned, TreeScope*) and scopedChild(TreeScope*) accept null for TreeScope* ?
Comment 3 Hajime Morrita 2012-09-30 21:46:31 PDT
Created attachment 166405 [details]
Patch
Comment 4 Hajime Morrita 2012-09-30 21:47:23 PDT
Kent-san, thanks for reviewing!

(In reply to comment #2)
> 
> Can you make scopedChild(unsigned, TreeScope*) and scopedChild(TreeScope*) accept null for TreeScope* ?
Done.
Comment 5 Kent Tamura 2012-09-30 21:57:03 PDT
Comment on attachment 166405 [details]
Patch

ok
Comment 6 WebKit Review Bot 2012-09-30 22:56:36 PDT
Comment on attachment 166405 [details]
Patch

Clearing flags on attachment: 166405

Committed r130006: <http://trac.webkit.org/changeset/130006>
Comment 7 WebKit Review Bot 2012-09-30 22:56:39 PDT
All reviewed patches have been landed.  Closing bug.