RESOLVED FIXED 97988
Crash on FrameTree::scopedChildCount() 
https://bugs.webkit.org/show_bug.cgi?id=97988
Summary Crash on FrameTree::scopedChildCount()
Hajime Morrita
Reported 2012-09-30 19:02:04 PDT
This upstreams http://code.google.com/p/chromium/issues/detail?id=131646
Attachments
Patch (2.23 KB, patch)
2012-09-30 19:06 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (2.39 KB, patch)
2012-09-30 21:46 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-09-30 19:06:40 PDT
Created attachment 166398 [details] Patch
Kent Tamura
Comment 2 2012-09-30 20:16:41 PDT
Comment on attachment 166398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166398&action=review > Source/WebCore/page/FrameTree.cpp:211 > + Document* document = m_thisFrame->document(); > + if (!document) > + return 0; > + return scopedChild(index, document); Can you make scopedChild(unsigned, TreeScope*) and scopedChild(TreeScope*) accept null for TreeScope* ?
Hajime Morrita
Comment 3 2012-09-30 21:46:31 PDT
Created attachment 166405 [details] Patch
Hajime Morrita
Comment 4 2012-09-30 21:47:23 PDT
Kent-san, thanks for reviewing! (In reply to comment #2) > > Can you make scopedChild(unsigned, TreeScope*) and scopedChild(TreeScope*) accept null for TreeScope* ? Done.
Kent Tamura
Comment 5 2012-09-30 21:57:03 PDT
Comment on attachment 166405 [details] Patch ok
WebKit Review Bot
Comment 6 2012-09-30 22:56:36 PDT
Comment on attachment 166405 [details] Patch Clearing flags on attachment: 166405 Committed r130006: <http://trac.webkit.org/changeset/130006>
WebKit Review Bot
Comment 7 2012-09-30 22:56:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.