RESOLVED FIXED 97976
Calendar picker should use zero as default step base 
https://bugs.webkit.org/show_bug.cgi?id=97976
Summary Calendar picker should use zero as default step base
Keishi Hattori
Reported 2012-09-30 06:38:02 PDT
Right now it is using minimum possible date.
Attachments
Patch (17.30 KB, patch)
2012-10-01 04:25 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (17.36 KB, patch)
2012-10-01 19:11 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-10-01 04:25:31 PDT
Created attachment 166447 [details] Patch
Kent Tamura
Comment 2 2012-10-01 17:23:08 PDT
Comment on attachment 166447 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166447&action=review r- because of some nits > Source/WebCore/ChangeLog:8 > + Calendar picker should be using zero as default step base for input type=date. Please add reasons why we should use zero instead of the hard minimum limit. e.g. specification, sync with our C++ implementation, sync with other browsers, etc. > Source/WebCore/html/shadow/CalendarPickerElement.cpp:145 > + parameters.stepBase = 0.0; should be 0 instead of 0.0 http://www.webkit.org/coding/coding-style.html#float-suffixes
Keishi Hattori
Comment 3 2012-10-01 19:11:58 PDT
Created attachment 166590 [details] Patch
Kent Tamura
Comment 4 2012-10-01 19:28:42 PDT
Comment on attachment 166590 [details] Patch ok
WebKit Review Bot
Comment 5 2012-10-01 19:37:14 PDT
Comment on attachment 166590 [details] Patch Clearing flags on attachment: 166590 Committed r130113: <http://trac.webkit.org/changeset/130113>
WebKit Review Bot
Comment 6 2012-10-01 19:37:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.