Bug 97976 - Calendar picker should use zero as default step base
Summary: Calendar picker should use zero as default step base
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-30 06:38 PDT by Keishi Hattori
Modified: 2012-10-01 19:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (17.30 KB, patch)
2012-10-01 04:25 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (17.36 KB, patch)
2012-10-01 19:11 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-09-30 06:38:02 PDT 
Right now it is using minimum possible date.
Comment 1 Keishi Hattori 2012-10-01 04:25:31 PDT 
Created attachment 166447 [details]
Patch
Comment 2 Kent Tamura 2012-10-01 17:23:08 PDT 
Comment on attachment 166447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166447&action=review

r- because of some nits

> Source/WebCore/ChangeLog:8
> +        Calendar picker should be using zero as default step base for input type=date.

Please add reasons why we should use zero instead of the hard minimum limit.  e.g. specification, sync with our C++ implementation, sync with other browsers, etc.

> Source/WebCore/html/shadow/CalendarPickerElement.cpp:145
> +        parameters.stepBase = 0.0;

should be 0 instead of 0.0
http://www.webkit.org/coding/coding-style.html#float-suffixes
Comment 3 Keishi Hattori 2012-10-01 19:11:58 PDT 
Created attachment 166590 [details]
Patch
Comment 4 Kent Tamura 2012-10-01 19:28:42 PDT 
Comment on attachment 166590 [details]
Patch

ok
Comment 5 WebKit Review Bot 2012-10-01 19:37:14 PDT 
Comment on attachment 166590 [details]
Patch

Clearing flags on attachment: 166590

Committed r130113: <http://trac.webkit.org/changeset/130113>
Comment 6 WebKit Review Bot 2012-10-01 19:37:17 PDT 
All reviewed patches have been landed.  Closing bug.