Bug 97963 - AsyncFileSystem::openFileSystem should have FileSystemType as a parameter.
Summary: AsyncFileSystem::openFileSystem should have FileSystemType as a parameter.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 91187
  Show dependency tree / graph
 
Reported: 2012-09-29 00:19 PDT by Dongwoo Joshua Im (dwim)
Modified: 2012-09-29 19:29 PDT (History)
7 users (show)

See Also:

Attachments
patch (7.72 KB, patch)
2012-09-29 00:49 PDT, Dongwoo Joshua Im (dwim) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongwoo Joshua Im (dwim) 2012-09-29 00:19:09 PDT 
I totally believe AsyncFileSystem::openFileSystem should have FileSystemType as a parameter.
FileSystemType is an important information to maintain the file system itself.

And, there is "FIXME" in the AsyncFileSystem.cpp, as well.
: // FIXME: Add FileSystemType parameter.

I'll upload patch soon.
Comment 1 Dongwoo Joshua Im (dwim) 2012-09-29 00:49:38 PDT 
Created attachment 166354 [details]
patch
Comment 2 Gyuyoung Kim 2012-09-29 05:34:40 PDT 
Comment on attachment 166354 [details]
patch

Looks good to me. Any other opinion in this patch ?
Comment 3 WebKit Review Bot 2012-09-29 19:29:43 PDT 
Comment on attachment 166354 [details]
patch

Clearing flags on attachment: 166354

Committed r129988: <http://trac.webkit.org/changeset/129988>
Comment 4 WebKit Review Bot 2012-09-29 19:29:47 PDT 
All reviewed patches have been landed.  Closing bug.