Bug 97953 – Kill transitive effects of SelectorChecker::checkOneSelector.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dimitri Glazkov (Google)]

Kill transitive effects of SelectorChecker::checkOneSelector.

[Dimitri Glazkov (Google)]

Created attachment 166329 [details]
WIP

[Eric Seidel (no email)]

Nice!

[Dimitri Glazkov (Google)]

Created attachment 166546 [details]
Patch

[Dimitri Glazkov (Google)]

Created attachment 166548 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 166548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166548&action=review

> Source/WebCore/css/SelectorChecker.cpp:448
> +    if (context.selector->m_match == CSSSelector::PseudoElement) {

None of the other callers care about this block?

[Dimitri Glazkov (Google)]

Comment on attachment 166548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166548&action=review

>> Source/WebCore/css/SelectorChecker.cpp:448
>> +    if (context.selector->m_match == CSSSelector::PseudoElement) {
> 
> None of the other callers care about this block?

Well, no -- since the code inside is operating on the assumption that it's looking at a pseudoelement selector :)

[Eric Seidel (no email)]

Comment on attachment 166548 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 166548 [details]
Patch

Clearing flags on attachment: 166548

Committed r130089: <http://trac.webkit.org/changeset/130089>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ojan Vafai]

This may have caused a performance regression on the dromaeo tests.

http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dromaeo_domcoremodify/report.html?history=150&rev=-1&graph=dom_modify
http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dom_perf/report.html?history=150&rev=-1&graph=CloneNodes
http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dromaeo_domcoremodify/report.html?history=150&rev=-1&graph=dom_modify_insertBefore
http://trac.webkit.org/log/?verbose=on&rev=130099&stop_rev=130089

[WebKit Review Bot]

Re-opened since this is blocked by bug 98181