Bug 97948 – flexbox does wrong baseline item alignment in columns

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Tony Chang]

The spec says, "If the flex item's inline axis is the same as the cross axis, this value is identical to ‘flex-start’."  We're not doing that.  See https://bugs.webkit.org/attachment.cgi?id=163005 for some test cases.

[Tony Chang]

Created attachment 166555 [details]
Patch

[Ojan Vafai]

Comment on attachment 166555 [details]
Patch

What if, instead of changing the logic of AlignBaseline, we made the chunk before the switch statement pretend that we have a different alignment. That would reduce some code duplication and more clearly match the spec text.

FlexAlign alignment = alignmentForChild(child);
if (alignment == AlignBaseline and hasOrthogonalFlow(child))
    alignment = (style()->flexWrap() == FlexWrapReverse) ? AlignFlexEnd : AlignFlexStart;

Up to you. I find this logic easier to follow.

[Tony Chang]

Created attachment 166563 [details]
Patch

[Tony Chang]

Created attachment 166564 [details]
Patch

[Tony Chang]

Comment on attachment 166564 [details]
Patch

Can you take another look? I moved the logic into alignmentForChild.

[WebKit Review Bot]

Comment on attachment 166564 [details]
Patch

Rejecting attachment 166564 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 159019 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
51>At revision 159019.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14089966

[Build Bot]

Comment on attachment 166564 [details]
Patch

Attachment 166564 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14084986

New failing tests:
http/tests/workers/terminate-during-sync-operation.html

[WebKit Review Bot]

Comment on attachment 166564 [details]
Patch

Clearing flags on attachment: 166564

Committed r130110: <http://trac.webkit.org/changeset/130110>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.