Bug 97942 - TextureMapperGL destructor crashes
Summary: TextureMapperGL destructor crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luiz Agostini
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-28 14:52 PDT by Luiz Agostini
Modified: 2012-09-29 13:10 PDT (History)
3 users (show)

See Also:

Attachments
patch (3.10 KB, patch)
2012-09-28 15:01 PDT, Luiz Agostini 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2012-09-28 14:52:51 PDT 
BitmapTextureGL destructor uses a TextureMapperGL instance on its destructor. The problem is that BitmapTextureGL objects are destroyed on TextureMapper destructor and at that time TextureMapperGL specific methods and data are not available any more.
Comment 1 Luiz Agostini 2012-09-28 15:01:41 PDT 
Created attachment 166317 [details]
patch
Comment 2 WebKit Review Bot 2012-09-28 16:07:23 PDT 
Comment on attachment 166317 [details]
patch

Clearing flags on attachment: 166317

Committed r129956: <http://trac.webkit.org/changeset/129956>
Comment 3 WebKit Review Bot 2012-09-28 16:07:26 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Martin Robinson 2012-09-29 13:10:28 PDT 
(In reply to comment #0)
> BitmapTextureGL destructor uses a TextureMapperGL instance on its destructor. The problem is that BitmapTextureGL objects are destroyed on TextureMapper destructor and at that time TextureMapperGL specific methods and data are not available any more.

Nice fix! I've created a complimentary patch here that also handles the case where the TextureMapper is destroyed, but a backing store still have references to the textures:

https://bugs.webkit.org/show_bug.cgi?id=97394